Merge lp:~markjtully/ubuntu-app-review-board/unity-scopes-music-extras-oneiric into lp:~app-review-board/ubuntu-app-review-board/unity-scopes-music-extras-oneiric

Proposed by Allison Randal
Status: Merged
Merged at revision: 17
Proposed branch: lp:~markjtully/ubuntu-app-review-board/unity-scopes-music-extras-oneiric
Merge into: lp:~app-review-board/ubuntu-app-review-board/unity-scopes-music-extras-oneiric
Diff against target: 21 lines (+2/-2)
1 file modified
scopes/guayadeque/unity-scope-guayadeque (+2/-2)
To merge this branch: bzr merge lp:~markjtully/ubuntu-app-review-board/unity-scopes-music-extras-oneiric
Reviewer Review Type Date Requested Status
Allison Randal (community) Approve
Review via email: mp+101211@code.launchpad.net

Description of the change

[from markjtully]
The problem was that the decade and genre checks were checking the wrong fields of the track (and panicking when it found what it thought was the year was in fact not a number at all). I've corrected these and it now functions correctly on my machine. This should allow us to publish all 4 scopes, and I can move on to updating them for Precise!

To post a comment you must log in.
Revision history for this message
Allison Randal (allison) wrote :

Fixes an off-by-one error in the array index.

review: Approve
17. By Allison Randal

Merging guayadeque fixes from markjtully

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scopes/guayadeque/unity-scope-guayadeque'
2--- scopes/guayadeque/unity-scope-guayadeque 2012-03-23 05:14:53 +0000
3+++ scopes/guayadeque/unity-scope-guayadeque 2012-04-08 18:08:17 +0000
4@@ -148,7 +148,7 @@
5 albumuri = "album://" + albumartist + "/" + album
6
7 # If the album is between the decades filtered, include.
8- if int(track[7]) >= firstdecadefilter and int(track[7]) <= lastdecadefilter:
9+ if int(track[8]) >= firstdecadefilter and int(track[8]) <= lastdecadefilter:
10 decade = "true"
11 else:
12 decade = "false"
13@@ -156,7 +156,7 @@
14 decade = "true"
15
16 # If the genre is a selected genre, include
17- if track[8].lower() in activegenre:
18+ if track[9].lower() in activegenre:
19 genre = "true"
20 else:
21 genre = "false"

Subscribers

People subscribed via source and target branches