Merge lp:~markgius/bzr-extmerge/git-mergetool-support into lp:~zindar/bzr-extmerge/trunk

Proposed by Mark Gius
Status: Needs review
Proposed branch: lp:~markgius/bzr-extmerge/git-mergetool-support
Merge into: lp:~zindar/bzr-extmerge/trunk
Diff against target: 15 lines (+4/-1)
1 file modified
extmerge.py (+4/-1)
To merge this branch: bzr merge lp:~markgius/bzr-extmerge/git-mergetool-support
Reviewer Review Type Date Requested Status
Fred McCann (community) Disapprove
Jelmer Vernooij (community) code Approve
Erik Bågfors Pending
Review via email: mp+63414@code.launchpad.net

Commit message

Adds accepted configuration for git-mergetool style merging.

Description of the change

Adds accepted configuration for git-mergetool style merging.

Left is local committed copy, middle is merged copy with markers, right is remote copy. This config works extremely well with vimdiff.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Looks reasonable to me (though I'm not a bzr-extmerge maintainer)

review: Approve (code)
Revision history for this message
Fred McCann (xred) wrote :

We've already accepted a proposal that covers this use case; ("%t", "%r", "%o") will be available in the next release.

review: Disapprove

Unmerged revisions

17. By Mark Gius

Add config for git-mergetool style merges

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extmerge.py'
2--- extmerge.py 2010-07-28 14:16:55 +0000
3+++ extmerge.py 2011-06-03 18:01:45 +0000
4@@ -35,7 +35,10 @@
5 # meld-style 3 way merge, one file (%T) being used for both in- and output
6 ('%b', '%T', '%o'),
7 # meld-style 2 way merge, one file (%T) being used for both in- and output
8- ('%T', '%o')
9+ ('%T', '%o'),
10+ # git mergetool style merge
11+ ('%t', '%r', '%o'),
12+
13 )
14
15 mergetools = [

Subscribers

People subscribed via source and target branches

to all changes: