Merge lp:~markellmtthw/postler/fix-920012 into lp:postler

Proposed by Matthew Markell
Status: Needs review
Proposed branch: lp:~markellmtthw/postler/fix-920012
Merge into: lp:postler
Diff against target: 241 lines (+22/-22)
22 files modified
postler/config.vapi (+1/-1)
postler/dexter.vala (+1/-1)
postler/dockmanager.vala (+1/-1)
postler/elementary-entry.vala (+1/-1)
postler/gtg.vala (+1/-1)
postler/indicate.vapi (+1/-1)
postler/postler-accounts.vala (+1/-1)
postler/postler-accountsetup.vala (+1/-1)
postler/postler-app.vala (+1/-1)
postler/postler-attachments.vala (+1/-1)
postler/postler-bureau.vala (+1/-1)
postler/postler-cellrendererconvo.vala (+1/-1)
postler/postler-cellrenderertoggle.vala (+1/-1)
postler/postler-client.vala (+1/-1)
postler/postler-composer.vala (+1/-1)
postler/postler-contact.vala (+1/-1)
postler/postler-content.vala (+1/-1)
postler/postler-flowbox.vala (+1/-1)
postler/postler-folders.vala (+1/-1)
postler/postler-index.vala (+1/-1)
postler/postler.vapi (+1/-1)
tests/parsing.vala (+1/-1)
To merge this branch: bzr merge lp:~markellmtthw/postler/fix-920012
Reviewer Review Type Date Requested Status
Ondergetekende (community) legal Disapprove
Danielle Foré Pending
Review via email: mp+91532@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ondergetekende (kvdveer) wrote :

From a legal perspective, this change is incorrect. Saying "copyright 2011" means: there are copyrightable elements in this source file, which were created in 2011. Saying "copyright 2011-2012" means there are copyrightable elements created in 2011 and copyrightable elements created in 2012.

All of the files you've retagged were last modified in 2011, so the 2012 tag doesn't make any sense there. In the mean time, some of these files may have been changed, but that is not enough: the change needs to be copyrightable. To be copyrightable, the change needs to be creative. For example: Fixing a buffer overlow or a typo is not creative. Adding a new dialog or algorithm is creative.

In the end, the year numbers on the file won't matter much. This being a legal issue, the question is: what will a judge decide. Any competent attorney will add the actual changelog (including the dates) to the dossier.

review: Disapprove (legal)

Unmerged revisions

1164. By Matthew Markell

changed copyright date to 20xx-2012

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'postler/config.vapi'
2--- postler/config.vapi 2011-01-02 18:27:36 +0000
3+++ postler/config.vapi 2012-02-04 03:24:19 +0000
4@@ -1,5 +1,5 @@
5 /*
6- Copyright (C) 2010 Christian Dywan <christian@twotoasts.de>
7+ Copyright (C) 2010-2012 Christian Dywan <christian@twotoasts.de>
8
9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Lesser General Public
11
12=== modified file 'postler/dexter.vala'
13--- postler/dexter.vala 2011-08-08 23:27:15 +0000
14+++ postler/dexter.vala 2012-02-04 03:24:19 +0000
15@@ -1,5 +1,5 @@
16 /*
17- Copyright (C) 2010 Christian Dywan <christian@twotoasts.de>
18+ Copyright (C) 2010-2012 Christian Dywan <christian@twotoasts.de>
19
20 This library is free software; you can redistribute it and/or
21 modify it under the terms of the GNU Lesser General Public
22
23=== modified file 'postler/dockmanager.vala'
24--- postler/dockmanager.vala 2011-03-30 20:38:19 +0000
25+++ postler/dockmanager.vala 2012-02-04 03:24:19 +0000
26@@ -1,5 +1,5 @@
27 /*
28- Copyright (C) 2011 Christian Dywan <christian@twotoasts.de>
29+ Copyright (C) 2011-2012 Christian Dywan <christian@twotoasts.de>
30
31 This library is free software; you can redistribute it and/or
32 modify it under the terms of the GNU Lesser General Public
33
34=== modified file 'postler/elementary-entry.vala'
35--- postler/elementary-entry.vala 2011-07-08 19:42:12 +0000
36+++ postler/elementary-entry.vala 2012-02-04 03:24:19 +0000
37@@ -1,5 +1,5 @@
38 /*
39- Copyright (C) 2011 Avi Romanoff <aviromanoff@gmail.com>
40+ Copyright (C) 2011-2012 Avi Romanoff <aviromanoff@gmail.com>
41
42 This library is free software; you can redistribute it and/or
43 modify it under the terms of the GNU Lesser General Public
44
45=== modified file 'postler/gtg.vala'
46--- postler/gtg.vala 2011-08-12 20:05:06 +0000
47+++ postler/gtg.vala 2012-02-04 03:24:19 +0000
48@@ -1,5 +1,5 @@
49 /*
50- Copyright (C) 2011 Christian Dywan <christian@twotoasts.de>
51+ Copyright (C) 2011-2012 Christian Dywan <christian@twotoasts.de>
52
53 This library is free software; you can redistribute it and/or
54 modify it under the terms of the GNU Lesser General Public
55
56=== modified file 'postler/indicate.vapi'
57--- postler/indicate.vapi 2011-07-02 20:47:58 +0000
58+++ postler/indicate.vapi 2012-02-04 03:24:19 +0000
59@@ -1,5 +1,5 @@
60 /*
61- Copyright (C) 2011 Christian Dywan <christian@twotoasts.de>
62+ Copyright (C) 2011-2012 Christian Dywan <christian@twotoasts.de>
63
64 This library is free software; you can redistribute it and/or
65 modify it under the terms of the GNU Lesser General Public
66
67=== modified file 'postler/postler-accounts.vala'
68--- postler/postler-accounts.vala 2011-09-05 23:18:59 +0000
69+++ postler/postler-accounts.vala 2012-02-04 03:24:19 +0000
70@@ -1,5 +1,5 @@
71 /*
72- Copyright (C) 2011 Christian Dywan <christian@twotoasts.de>
73+ Copyright (C) 2011-2012 Christian Dywan <christian@twotoasts.de>
74
75 This library is free software; you can redistribute it and/or
76 modify it under the terms of the GNU Lesser General Public
77
78=== modified file 'postler/postler-accountsetup.vala'
79--- postler/postler-accountsetup.vala 2011-07-05 19:57:16 +0000
80+++ postler/postler-accountsetup.vala 2012-02-04 03:24:19 +0000
81@@ -1,5 +1,5 @@
82 /*
83- Copyright (C) 2011 Christian Dywan <christian@twotoasts.de>
84+ Copyright (C) 2011-2012 Christian Dywan <christian@twotoasts.de>
85
86 This library is free software; you can redistribute it and/or
87 modify it under the terms of the GNU Lesser General Public
88
89=== modified file 'postler/postler-app.vala'
90--- postler/postler-app.vala 2011-08-15 21:18:40 +0000
91+++ postler/postler-app.vala 2012-02-04 03:24:19 +0000
92@@ -1,5 +1,5 @@
93 /*
94- Copyright (C) 2010 Christian Dywan <christian@twotoasts.de>
95+ Copyright (C) 2010-2012 Christian Dywan <christian@twotoasts.de>
96
97 This library is free software; you can redistribute it and/or
98 modify it under the terms of the GNU Lesser General Public
99
100=== modified file 'postler/postler-attachments.vala'
101--- postler/postler-attachments.vala 2011-02-14 23:34:07 +0000
102+++ postler/postler-attachments.vala 2012-02-04 03:24:19 +0000
103@@ -1,5 +1,5 @@
104 /*
105- Copyright (C) 2011 Christian Dywan <christian@twotoasts.de>
106+ Copyright (C) 2011-2012 Christian Dywan <christian@twotoasts.de>
107
108 This library is free software; you can redistribute it and/or
109 modify it under the terms of the GNU Lesser General Public
110
111=== modified file 'postler/postler-bureau.vala'
112--- postler/postler-bureau.vala 2011-08-15 21:18:40 +0000
113+++ postler/postler-bureau.vala 2012-02-04 03:24:19 +0000
114@@ -1,5 +1,5 @@
115 /*
116- Copyright (C) 2011 Christian Dywan <christian@twotoasts.de>
117+ Copyright (C) 2011-2012 Christian Dywan <christian@twotoasts.de>
118
119 This library is free software; you can redistribute it and/or
120 modify it under the terms of the GNU Lesser General Public
121
122=== modified file 'postler/postler-cellrendererconvo.vala'
123--- postler/postler-cellrendererconvo.vala 2011-09-05 23:18:59 +0000
124+++ postler/postler-cellrendererconvo.vala 2012-02-04 03:24:19 +0000
125@@ -1,5 +1,5 @@
126 /*
127- Copyright (C) 2011 Lucas Baudin <xapantu@gmail.com>
128+ Copyright (C) 2011-2012 Lucas Baudin <xapantu@gmail.com>
129
130 This library is free software; you can redistribute it and/or
131 modify it under the terms of the GNU Lesser General Public
132
133=== modified file 'postler/postler-cellrenderertoggle.vala'
134--- postler/postler-cellrenderertoggle.vala 2011-07-16 23:26:29 +0000
135+++ postler/postler-cellrenderertoggle.vala 2012-02-04 03:24:19 +0000
136@@ -1,5 +1,5 @@
137 /*
138- Copyright (C) 2010 Christian Dywan <christian@twotoasts.de>
139+ Copyright (C) 2010-2012 Christian Dywan <christian@twotoasts.de>
140
141 This library is free software; you can redistribute it and/or
142 modify it under the terms of the GNU Lesser General Public
143
144=== modified file 'postler/postler-client.vala'
145--- postler/postler-client.vala 2011-09-05 23:18:59 +0000
146+++ postler/postler-client.vala 2012-02-04 03:24:19 +0000
147@@ -1,5 +1,5 @@
148 /*
149- Copyright (C) 2011 Christian Dywan <christian@twotoasts.de>
150+ Copyright (C) 2011-2012 Christian Dywan <christian@twotoasts.de>
151
152 This library is free software; you can redistribute it and/or
153 modify it under the terms of the GNU Lesser General Public
154
155=== modified file 'postler/postler-composer.vala'
156--- postler/postler-composer.vala 2011-07-05 19:57:16 +0000
157+++ postler/postler-composer.vala 2012-02-04 03:24:19 +0000
158@@ -1,5 +1,5 @@
159 /*
160- Copyright (C) 2011 Christian Dywan <christian@twotoasts.de>
161+ Copyright (C) 2011-2012 Christian Dywan <christian@twotoasts.de>
162
163 This library is free software; you can redistribute it and/or
164 modify it under the terms of the GNU Lesser General Public
165
166=== modified file 'postler/postler-contact.vala'
167--- postler/postler-contact.vala 2011-06-29 18:00:59 +0000
168+++ postler/postler-contact.vala 2012-02-04 03:24:19 +0000
169@@ -1,5 +1,5 @@
170 /*
171- Copyright (C) 2011 Christian Dywan <christian@twotoasts.de>
172+ Copyright (C) 2011-2012 Christian Dywan <christian@twotoasts.de>
173
174 This library is free software; you can redistribute it and/or
175 modify it under the terms of the GNU Lesser General Public
176
177=== modified file 'postler/postler-content.vala'
178--- postler/postler-content.vala 2011-09-05 23:18:59 +0000
179+++ postler/postler-content.vala 2012-02-04 03:24:19 +0000
180@@ -1,5 +1,5 @@
181 /*
182- Copyright (C) 2011 Christian Dywan <christian@twotoasts.de>
183+ Copyright (C) 2011-2012 Christian Dywan <christian@twotoasts.de>
184
185 This library is free software; you can redistribute it and/or
186 modify it under the terms of the GNU Lesser General Public
187
188=== modified file 'postler/postler-flowbox.vala'
189--- postler/postler-flowbox.vala 2011-07-07 17:57:16 +0000
190+++ postler/postler-flowbox.vala 2012-02-04 03:24:19 +0000
191@@ -1,5 +1,5 @@
192 /*
193- Copyright (C) 2011 Christian Dywan <christian@twotoasts.de>
194+ Copyright (C) 2011-2012 Christian Dywan <christian@twotoasts.de>
195
196 This library is free software; you can redistribute it and/or
197 modify it under the terms of the GNU Lesser General Public
198
199=== modified file 'postler/postler-folders.vala'
200--- postler/postler-folders.vala 2011-08-04 01:18:58 +0000
201+++ postler/postler-folders.vala 2012-02-04 03:24:19 +0000
202@@ -1,5 +1,5 @@
203 /*
204- Copyright (C) 2011 Christian Dywan <christian@twotoasts.de>
205+ Copyright (C) 2011-2012 Christian Dywan <christian@twotoasts.de>
206
207 This library is free software; you can redistribute it and/or
208 modify it under the terms of the GNU Lesser General Public
209
210=== modified file 'postler/postler-index.vala'
211--- postler/postler-index.vala 2011-08-12 20:05:06 +0000
212+++ postler/postler-index.vala 2012-02-04 03:24:19 +0000
213@@ -1,5 +1,5 @@
214 /*
215- Copyright (C) 2011 Christian Dywan <christian@twotoasts.de>
216+ Copyright (C) 2011-2012 Christian Dywan <christian@twotoasts.de>
217
218 This library is free software; you can redistribute it and/or
219 modify it under the terms of the GNU Lesser General Public
220
221=== modified file 'postler/postler.vapi'
222--- postler/postler.vapi 2011-08-10 22:35:45 +0000
223+++ postler/postler.vapi 2012-02-04 03:24:19 +0000
224@@ -1,5 +1,5 @@
225 /*
226- Copyright (C) 2010 Christian Dywan <christian@twotoasts.de>
227+ Copyright (C) 2010-2012 Christian Dywan <christian@twotoasts.de>
228
229 This library is free software; you can redistribute it and/or
230 modify it under the terms of the GNU Lesser General Public
231
232=== modified file 'tests/parsing.vala'
233--- tests/parsing.vala 2011-06-23 18:59:06 +0000
234+++ tests/parsing.vala 2012-02-04 03:24:19 +0000
235@@ -1,5 +1,5 @@
236 /*
237- Copyright (C) 2011 Christian Dywan <christian@twotoasts.de>
238+ Copyright (C) 2011-2012 Christian Dywan <christian@twotoasts.de>
239
240 This library is free software; you can redistribute it and/or
241 modify it under the terms of the GNU Lesser General Public

Subscribers

People subscribed via source and target branches

to status/vote changes: