Merge lp:~markellmtthw/postler/fix-920012 into lp:postler
Proposed by
Matthew Markell
Status: | Needs review | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~markellmtthw/postler/fix-920012 | ||||
Merge into: | lp:postler | ||||
Diff against target: |
241 lines (+22/-22) 22 files modified
postler/config.vapi (+1/-1) postler/dexter.vala (+1/-1) postler/dockmanager.vala (+1/-1) postler/elementary-entry.vala (+1/-1) postler/gtg.vala (+1/-1) postler/indicate.vapi (+1/-1) postler/postler-accounts.vala (+1/-1) postler/postler-accountsetup.vala (+1/-1) postler/postler-app.vala (+1/-1) postler/postler-attachments.vala (+1/-1) postler/postler-bureau.vala (+1/-1) postler/postler-cellrendererconvo.vala (+1/-1) postler/postler-cellrenderertoggle.vala (+1/-1) postler/postler-client.vala (+1/-1) postler/postler-composer.vala (+1/-1) postler/postler-contact.vala (+1/-1) postler/postler-content.vala (+1/-1) postler/postler-flowbox.vala (+1/-1) postler/postler-folders.vala (+1/-1) postler/postler-index.vala (+1/-1) postler/postler.vapi (+1/-1) tests/parsing.vala (+1/-1) |
||||
To merge this branch: | bzr merge lp:~markellmtthw/postler/fix-920012 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ondergetekende (community) | legal | Disapprove | |
Danielle Foré | Pending | ||
Review via email: mp+91532@code.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 1164. By Matthew Markell
-
changed copyright date to 20xx-2012
From a legal perspective, this change is incorrect. Saying "copyright 2011" means: there are copyrightable elements in this source file, which were created in 2011. Saying "copyright 2011-2012" means there are copyrightable elements created in 2011 and copyrightable elements created in 2012.
All of the files you've retagged were last modified in 2011, so the 2012 tag doesn't make any sense there. In the mean time, some of these files may have been changed, but that is not enough: the change needs to be copyrightable. To be copyrightable, the change needs to be creative. For example: Fixing a buffer overlow or a typo is not creative. Adding a new dialog or algorithm is creative.
In the end, the year numbers on the file won't matter much. This being a legal issue, the question is: what will a judge decide. Any competent attorney will add the actual changelog (including the dates) to the dossier.