Merge lp:~markellmtthw/postler/fix-917023 into lp:postler

Proposed by Matthew Markell
Status: Needs review
Proposed branch: lp:~markellmtthw/postler/fix-917023
Merge into: lp:postler
Diff against target: 16 lines (+2/-3)
1 file modified
data/postler.desktop.in (+2/-3)
To merge this branch: bzr merge lp:~markellmtthw/postler/fix-917023
Reviewer Review Type Date Requested Status
Cassidy James Blaede (community) Approve
Danielle Foré Pending
Review via email: mp+88774@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

I think the GenericName would make more sense to just be "Email", wouldn't it?

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

In fact, that's an interesting case. It wouldn't make sense to say, "Postler is an email," so I've added this bit to the HIG:

For apps where you'd best describe it with a noun and then "App," just use the noun. For example, Postler is an email app, but its generic name should be "Email." Similarly, Switchboard is a settings app, so its generic name is "Settings."

review: Needs Fixing
Revision history for this message
Matthew Markell (markellmtthw) wrote :

Hmm, I thought about this and I didn't really like Mail Reader, but Email seems too simplistic. I can't really think of a better idea though, so I'll go ahead and change it.

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

And actually, now I'm wondering if it should be that way for ALL generic names. So instead of Noun Verber (Web Browser, Music Player, Mail Reader, File Manager, Text Editor), you'd just have Noun (Internet, Music, Email, Files, Text). Hm...

Revision history for this message
Matthew Markell (markellmtthw) wrote :

> And actually, now I'm wondering if it should be that way for ALL generic
> names. So instead of Noun Verber (Web Browser, Music Player, Mail Reader, File
> Manager, Text Editor), you'd just have Noun (Internet, Music, Email, Files,
> Text). Hm...

I don't think that would work unless you have a very limited app ecosystem. If a program is named Music then does it manage your music or is it a retagger. Do we call both Totoem and BeatBox 'Music'? This seems to be way over simplified.

Revision history for this message
Matthew Markell (markellmtthw) wrote :

Also, what IS Postler? Is it an Email? No, it's an Email Client or Reader. What IS Marlin? Is it a Files? No, it's a File Manager.

My .02

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Title is a(n) GenericName that lets you Comment.

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

w00t, Postler is a Mail Reader that lets you Send and receive email.

review: Approve

Unmerged revisions

1156. By Matthew Markell

change .desktop to conform to HIG

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/postler.desktop.in'
2--- data/postler.desktop.in 2011-05-13 13:44:19 +0000
3+++ data/postler.desktop.in 2012-01-16 21:06:26 +0000
4@@ -1,10 +1,9 @@
5-
6 [Desktop Entry]
7 Version=1.0
8 Type=Application
9 _Name=Postler
10-_GenericName=Mail reader
11-_Comment=Lean mail interface
12+_GenericName=Mail Reader
13+_Comment=Send and receive email
14 Categories=GTK;Network;Email;
15 MimeType=application/mbox;x-scheme-handler/mailto;
16 Exec=postler %u

Subscribers

People subscribed via source and target branches

to status/vote changes: