Merge lp:~markellmtthw/midori/fix-917023 into lp:~vcs-imports/midori/master

Proposed by Matthew Markell
Status: Merged
Merge reported by: Cris Dywan
Merged at revision: not available
Proposed branch: lp:~markellmtthw/midori/fix-917023
Merge into: lp:~vcs-imports/midori/master
Diff against target: 25 lines (+2/-2)
2 files modified
data/midori-private.desktop.in (+1/-1)
data/midori.desktop.in (+1/-1)
To merge this branch: bzr merge lp:~markellmtthw/midori/fix-917023
Reviewer Review Type Date Requested Status
Cassidy James Blaede (community) Needs Information
VCS imports Pending
Review via email: mp+88768@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Not sure if it should be "Browse the Web" or "Browse the Internet." My first instinct is "Internet," but I'm not sure and would like feedback. Also, why is private browsing mode still its own .desktop?! It should really be a QuickList action by now IMHO...

review: Needs Information
Revision history for this message
Matthew Markell (markellmtthw) wrote :

I used browse the web because Midori is a Web Browser that lets you
Browse the Web. Could be either way though.

Midori does have a Unity quicklist with private browsing. However,
Midori is also used by XFCE and other lightweight environments that
don't support quicklists.

On 01/16/2012 10:25 PM, Cassidy James wrote:
> Review: Needs Information
>
> Not sure if it should be "Browse the Web" or "Browse the Internet." My first instinct is "Internet," but I'm not sure and would like feedback. Also, why is private browsing mode still its own .desktop?! It should really be a QuickList action by now IMHO...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/midori-private.desktop.in'
2--- data/midori-private.desktop.in 2011-11-15 17:34:19 +0000
3+++ data/midori-private.desktop.in 2012-01-16 20:35:32 +0000
4@@ -3,7 +3,7 @@
5 Type=Application
6 _Name=Midori Private Browsing
7 _GenericName=Private Browsing
8-_Comment=Open a new private browsing window
9+_Comment=Browse the Web in private mode
10 Categories=GTK;Network;WebBrowser;
11 Exec=midori --private %U
12 Icon=midori
13
14=== modified file 'data/midori.desktop.in'
15--- data/midori.desktop.in 2011-11-24 23:59:48 +0000
16+++ data/midori.desktop.in 2012-01-16 20:35:32 +0000
17@@ -3,7 +3,7 @@
18 Type=Application
19 _Name=Midori
20 _GenericName=Web Browser
21-_Comment=Lightweight web browser
22+_Comment=Browse the Web
23 _X-GNOME-Keywords=Internet;WWW;Explorer
24 _X-AppInstall-Keywords=Internet;WWW;Explorer
25 Categories=GTK;Network;WebBrowser;

Subscribers

People subscribed via source and target branches

to all changes: