Merge lp:~markellmtthw/cerbere/fix-932224 into lp:~elementary-pantheon/cerbere/cerbere

Proposed by Matthew Markell
Status: Merged
Merged at revision: 26
Proposed branch: lp:~markellmtthw/cerbere/fix-932224
Merge into: lp:~elementary-pantheon/cerbere/cerbere
Diff against target: 24 lines (+15/-5)
1 file modified
INSTALL (+15/-5)
To merge this branch: bzr merge lp:~markellmtthw/cerbere/fix-932224
Reviewer Review Type Date Requested Status
Victor Martinez (community) Approve
Review via email: mp+93423@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Victor Martinez (victored) wrote :

In agree on everything except:
1) bzr branch lp:cerbere
2 )cd cerbere

If a user is able to read the file is because they already have the branch :)

review: Needs Fixing
Revision history for this message
Matthew Markell (markellmtthw) wrote :

Unless they are using Launchpads web interface :P I'll change it.

-----Original Message-----
From: Victor Eduardo <email address hidden>
To: Matthew Markell <email address hidden>
Sent: Thu, May 17, 2012 7:24 pm
Subject: Re: [Merge] lp:~markellmtthw/cerbere/fix-932224 into lp:cerbere

Review: Needs Fixing

In agree on everything except:
1) bzr branch lp:cerbere
2 )cd cerbere

If a user is able to read the file is because they already have the branch :)
--
https://code.launchpad.net/~markellmtthw/cerbere/fix-932224/+merge/93423
You are the owner of lp:~markellmtthw/cerbere/fix-932224.

Revision history for this message
Victor Martinez (victored) wrote :

Matthew, I'll make the modifications I suggested before committing.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'INSTALL'
2--- INSTALL 2012-02-11 21:34:28 +0000
3+++ INSTALL 2012-02-16 15:08:22 +0000
4@@ -1,5 +1,15 @@
5-mkdir build
6-cd build
7-cmake ..
8-make
9-sudo make install
10+Dependencies:
11+ debhelper (>= 7.0.50~)
12+ cmake (>= 2.6)
13+ libglib2.0-dev (>= 2.28)
14+ valac (>= 0.10)
15+ libgee-dev (>= 0.5.3)
16+
17+Build:
18+ bzr branch lp:cerbere
19+ cd cerbere
20+ mkdir build
21+ cd build
22+ cmake .. -DCMAKE_INSTALL_PREFIX=/usr
23+ make
24+ sudo make install

Subscribers

People subscribed via source and target branches

to all changes: