Merge lp:~mark-mims/ubuntu/precise/ganglia/useradd into lp:ubuntu/precise/ganglia

Proposed by Mark Mims
Status: Merged
Merged at revision: 11
Proposed branch: lp:~mark-mims/ubuntu/precise/ganglia/useradd
Merge into: lp:ubuntu/precise/ganglia
Diff against target: 61 lines (+8/-20)
3 files modified
debian/changelog (+6/-0)
debian/ganglia-monitor.postinst (+1/-10)
debian/gmetad.postinst (+1/-10)
To merge this branch: bzr merge lp:~mark-mims/ubuntu/precise/ganglia/useradd
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+85387@code.launchpad.net

Description of the change

Fix useradd options, Closes #854866

To post a comment you must log in.
Revision history for this message
Mark Mims (mark-mims) wrote :

Not sure what needs to be done process-wise for oneiric, but lp:~mark-mims/ubuntu/oneiric/ganglia/useradd is identical to this branch.

Revision history for this message
Scott Moser (smoser) wrote :

Mark,
  I merged this in and uploaded to precise.
  There were a couple things that I fixed:
   * the new version should be '3.1.7-2ubuntu1', not '3.1.7-3' as it is an ubuntu package now.
   * the release should either be 'UNRELEASED' or 'precise' (not 'unstable')
   * in order to upload a package with diff from debian, you have to have a Maintainer in debian/control that has an ubuntu.com email address. Ie 'Ubuntu Developers <email address hidden>'.

   Note, you can use 'dch -i' to edit a debian/changelog and it will do some of that for you.

   With regard to oneiric, we can SRU that. You should follow the steps in https://wiki.ubuntu.com/StableReleaseUpdates . it takes some process, but the first step of that process is to get it into the development version.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-04-07 21:26:32 +0000
3+++ debian/changelog 2011-12-12 19:59:26 +0000
4@@ -1,3 +1,9 @@
5+ganglia (3.1.7-3) unstable; urgency=low
6+
7+ * Fix options on useradd in postinst. Closes: #854866
8+
9+ -- Mark Mims <mark.mims@canonical.com> Mon, 12 Dec 2011 13:44:39 -0600
10+
11 ganglia (3.1.7-2) unstable; urgency=low
12
13 * Stop ganglia-monitor from changing permissions on /var/lib/ganglia
14
15=== modified file 'debian/ganglia-monitor.postinst'
16--- debian/ganglia-monitor.postinst 2011-04-07 21:26:32 +0000
17+++ debian/ganglia-monitor.postinst 2011-12-12 19:59:26 +0000
18@@ -1,18 +1,9 @@
19 #!/bin/sh
20 set -e
21
22-if ! getent group ganglia >/dev/null; then
23- echo Adding group: ganglia.
24- groupadd --system ganglia
25-fi
26-
27 if ! getent passwd ganglia >/dev/null; then
28 echo Adding system user: ganglia.
29- useradd --system ganglia
30- usermod -c "Ganglia Monitor" ganglia
31- usermod -d "/var/lib/ganglia" ganglia
32- usermod -g "ganglia" ganglia
33- usermod -s "/bin/false" ganglia
34+ useradd -r -c "Ganglia Monitor" -d "/var/lib/ganglia" -s "/bin/false" -U ganglia
35 fi
36
37 #if we have an old 2.5.x gmond
38
39=== modified file 'debian/gmetad.postinst'
40--- debian/gmetad.postinst 2011-04-07 21:26:32 +0000
41+++ debian/gmetad.postinst 2011-12-12 19:59:26 +0000
42@@ -1,18 +1,9 @@
43 #!/bin/sh
44 set -e
45
46-if ! getent group ganglia >/dev/null; then
47- echo Adding group: ganglia.
48- groupadd --system ganglia
49-fi
50-
51 if ! getent passwd ganglia >/dev/null; then
52 echo Adding system user: ganglia.
53- useradd --system ganglia
54- usermod -c "Ganglia Monitor" ganglia
55- usermod -d "/var/lib/ganglia" ganglia
56- usermod -g "ganglia" ganglia
57- usermod -s "/bin/false" ganglia
58+ useradd -r -c "Ganglia Monitor" -d "/var/lib/ganglia" -s "/bin/false" -U ganglia
59 fi
60
61 if [ ! -d /var/lib/ganglia/rrds ]; then

Subscribers

People subscribed via source and target branches

to all changes: