Merge lp:~mariosplivalo/charms/trusty/percona-cluster/enable-binlogs into lp:~openstack-charmers-archive/charms/trusty/percona-cluster/next
Status: | Superseded |
---|---|
Proposed branch: | lp:~mariosplivalo/charms/trusty/percona-cluster/enable-binlogs |
Merge into: | lp:~openstack-charmers-archive/charms/trusty/percona-cluster/next |
Prerequisite: | lp:~niedbalski/charms/trusty/percona-cluster/fix-1425528 |
Diff against target: |
88 lines (+38/-1) 3 files modified
config.yaml (+11/-0) hooks/percona_hooks.py (+23/-1) templates/my.cnf (+4/-0) |
To merge this branch: | bzr merge lp:~mariosplivalo/charms/trusty/percona-cluster/enable-binlogs |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Page | Needs Fixing | ||
Felipe Reyes | Needs Fixing | ||
Edward Hope-Morley | Pending | ||
Billy Olsen | Pending | ||
Jorge Niedbalski | Pending | ||
Review via email: mp+252248@code.launchpad.net |
This proposal has been superseded by a proposal from 2015-10-14.
Description of the change
This adds two charm configuration options - enable_binlogs and binlogs_path. Binlog_path defaults to /var/log/
Unmerged revisions
- 61. By Mario Splivalo
-
Conflicts resolved (work from another workstation)
- 60. By Mario Splivalo
-
Merged /next
- 59. By Mario Splivalo
-
Isolate creation of binlog directory into a separate function
- 58. By Mario Splivalo
-
Merged from /next
- 57. By Mario Splivalo
-
Fixed typos, as suggested by freyes
- 56. By Mario Splivalo
-
Fix lint errors
- 55. By Mario Splivalo
-
Remove call to lchownr as it won't change owner of the base directory.
Instead, use os.chown. - 54. By Mario Splivalo
-
Fix directory creation
- 53. By Mario Splivalo
-
Make sure mysql can start even when binlog_path is pointing to
nonexistant path - 52. By Mario Splivalo
-
Create binlog_directory, if missing
Hi Mario,
This feature makes a lot of sense, and it worked for me, but please add unit tests for your patch, I also have minor comments in the diff.
Thanks,