Merge lp:~mariosplivalo/charm-helpers/pip_update into lp:charm-helpers

Proposed by Mario Splivalo
Status: Merged
Merged at revision: 286
Proposed branch: lp:~mariosplivalo/charm-helpers/pip_update
Merge into: lp:charm-helpers
Diff against target: 70 lines (+7/-26)
4 files modified
.bzrignore (+3/-0)
.project (+0/-17)
.pydevproject (+0/-8)
charmhelpers/contrib/python/packages.py (+4/-1)
To merge this branch: bzr merge lp:~mariosplivalo/charm-helpers/pip_update
Reviewer Review Type Date Requested Status
Jorge Niedbalski (community) Approve
Review via email: mp+246915@code.launchpad.net

Description of the change

Added option to pip_install to provide --upgrade, if needed.

Also, removed Eclipse-specific files (added them to .bzrignore too)

To post a comment you must log in.
Revision history for this message
Mario Splivalo (mariosplivalo) wrote :

I didn't add '--upgrade' to 'options' as that is 'reserved' for key-value options (which is not case for --upgrade).
Also, that would require modifying 'parse_options'.

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.bzrignore'
2--- .bzrignore 2014-11-25 15:04:52 +0000
3+++ .bzrignore 2015-01-19 16:24:23 +0000
4@@ -7,5 +7,8 @@
5 .env/
6 coverage.xml
7 docs/_build
8+.project
9+.pydevproject
10+.settings
11 .venv
12 .venv3
13
14=== removed file '.project'
15--- .project 2014-07-02 09:39:03 +0000
16+++ .project 1970-01-01 00:00:00 +0000
17@@ -1,17 +0,0 @@
18-<?xml version="1.0" encoding="UTF-8"?>
19-<projectDescription>
20- <name>charm-helpers</name>
21- <comment></comment>
22- <projects>
23- </projects>
24- <buildSpec>
25- <buildCommand>
26- <name>org.python.pydev.PyDevBuilder</name>
27- <arguments>
28- </arguments>
29- </buildCommand>
30- </buildSpec>
31- <natures>
32- <nature>org.python.pydev.pythonNature</nature>
33- </natures>
34-</projectDescription>
35
36=== removed file '.pydevproject'
37--- .pydevproject 2014-07-02 09:39:03 +0000
38+++ .pydevproject 1970-01-01 00:00:00 +0000
39@@ -1,8 +0,0 @@
40-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
41-<?eclipse-pydev version="1.0"?><pydev_project>
42-<pydev_pathproperty name="org.python.pydev.PROJECT_SOURCE_PATH">
43-<path>/charm-helpers</path>
44-</pydev_pathproperty>
45-<pydev_property name="org.python.pydev.PYTHON_PROJECT_VERSION">python 2.7</pydev_property>
46-<pydev_property name="org.python.pydev.PYTHON_PROJECT_INTERPRETER">Default</pydev_property>
47-</pydev_project>
48
49=== modified file 'charmhelpers/contrib/python/packages.py'
50--- charmhelpers/contrib/python/packages.py 2014-11-26 04:52:18 +0000
51+++ charmhelpers/contrib/python/packages.py 2015-01-19 16:24:23 +0000
52@@ -35,7 +35,7 @@
53 pip_execute(command)
54
55
56-def pip_install(package, fatal=False, **options):
57+def pip_install(package, fatal=False, upgrade=False, **options):
58 """Install a python package"""
59 command = ["install"]
60
61@@ -43,6 +43,9 @@
62 for option in parse_options(options, available_options):
63 command.append(option)
64
65+ if upgrade:
66+ command.append('--upgrade')
67+
68 if isinstance(package, list):
69 command.extend(package)
70 else:

Subscribers

People subscribed via source and target branches