maria:10.3-alter

Last commit made on 2018-02-19
Get this branch:
git clone -b 10.3-alter https://git.launchpad.net/maria

Branch merges

Branch information

Name:
10.3-alter
Repository:
lp:maria

Recent commits

2ba0785... by Monty <email address hidden>

Move alter partition flags to alter_info->partition_flags

This is done to get more free flag bits for alter_info->flags

Renamed all ALTER PARTITION defines to start with ALTER_PARTITION_
Renamed ALTER_PARTITION to ALTER_PARTITION_INFO
Renamed ALTER_TABLE_REORG to ALTER_PARTITION_TABLE_REORG

Other things:
- Shifted some ALTER_xxx defines to get empty bits at end

778f76a... by Monty <email address hidden>

Changed static const in Alter_info and Alter_online_info to defines

Main reason was to make it easier to print the above structures in
a debugger. Additional benefits is that I was able to use same
defines for both structures, which simplifes some code.

Most of the code is just removing Alter_info:: and Alter_inplace_info::
from alter table flags.

Following renames was done:
HA_ALTER_FLAGS -> alter_table_operations
CHANGE_CREATE_OPTION -> ALTER_CHANGE_CREATE_OPTION
Alter_info::ADD_INDEX -> ALTER_ADD_INDEX
DROP_INDEX -> ALTER_DROP_INDEX
ADD_UNIQUE_INDEX -> ALTER_ADD_UNIQUE_INDEX
DROP_UNIQUE_INDEx -> ALTER_DROP_UNIQUE_INDEX
ADD_PK_INDEX -> ALTER_ADD_PK_INDEX
DROP_PK_INDEX -> ALTER_DROP_PK_INDEX
Alter_info:ALTER_ADD_COLUMN -> ALTER_PARSE_ADD_COLUMN
Alter_info:ALTER_DROP_COLUMN -> ALTER_PARSE_DROP_COLUMN
Alter_inplace_info::ADD_INDEX -> ALTER_ADD_NON_UNIQUE_NON_PRIM_INDEX
Alter_inplace_info::DROP_INDEX -> ALTER_DROP_NON_UNIQUE_NON_PRIM_INDEX

Other things:
- Added typedef alter_table_operatons for alter table flags
- DROP CHECK CONSTRAINT can now be done online
- Added checks for Aria tables in alter_table_online.test
- alter_table_flags now takes an ulonglong as argument.
- Don't support online operations if checksum option is used.
- sql_lex.cc doesn't add ALTER_ADD_INDEX if index is not created

3e76816... by Monty <email address hidden>

Fixed some DBUG_PRINT to use %p properly

af1f4ff... by Monty <email address hidden>

Fixed alter online table for Aria tables

fill_alter_table() always thought that index was changed because of
of a wrong check of block_size. Some engines had code to correct this
that should not be needed, Aria didn't and because of this some online
operations didn't work.

This code fixes the comparision of block_size to only compare if it's set.

afc56a5... by shk

merge two the same consistently 'if' clauses into one

we have two the same 'if' clauses that check opt_bin_log argument
in mysqld.cc and both clauses go successively one after another.
Let's merge them into one

f8bdf4d... by shk

remove duplicated inclusion of derror.h

8ab37bb... by shk

fix comment in my_decimal_set_zero()

which says:

    We need the up-cast here, since my_decimal has sign() member functions,
    which conflicts with decimal_t::size

But decimal_t does not provide `size` field.

990289a... by Vladislav Vaintroub

Fix DBUG_PRINT formatting for ulonglong alter_info.flags

633d252... by Marko Mäkelä

Merge bb-10.2-ext into 10.3

f40c11d... by Marko Mäkelä

After-merge fix: Use matching format