Code review comment for lp:~maria-captains/bzr/diffoptions
Revision history for this message
| Martin Packman (gz) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
+ # if the user requested function names in the diff
+ # we use the external diff
My main issue with this kind of change is that actually using an external diff rather than the bzr internal one *can* be a big behaviour change. Some people don't have an external diff installed at all, and encoding handling is completely different.
If it's happening in non-obvious circumstances, we risk confusing users over when diff works the way they expect and when it breaks. Implementing '-F' in the bzr internal differ is way more work, but would also do what you want here I think.