Merge lp:~mardy/unity8/lp1433442 into lp:unity8
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Albert Astals Cid | ||||
Approved revision: | 1919 | ||||
Merged at revision: | 1923 | ||||
Proposed branch: | lp:~mardy/unity8/lp1433442 | ||||
Merge into: | lp:unity8 | ||||
Prerequisite: | lp:~aacid/unity8/previews_in_order | ||||
Diff against target: |
15 lines (+2/-2) 1 file modified
qml/Dash/PreviewListView.qml (+2/-2) |
||||
To merge this branch: | bzr merge lp:~mardy/unity8/lp1433442 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Albert Astals Cid (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Review via email: mp+268218@code.launchpad.net |
This proposal supersedes a proposal from 2015-08-14.
Commit message
Set currentIndex after the model change is completed
When setting the model, the list view will first emit the countChanged signal, then will change the currentIndex to 0 (see QtDeclarative git commit 22c6873 and https:/
If we set the currentIndex in the onCountChanged handler (as we were doing
before), the currentIndex would be reset to 0 shortly afterwards.
For some mysterious reason, the desired delegate was anyway shown until the bugfix for bug 1433442 was introduced; with that bugfix, the listview is more consistent and shows the delegate corresponding to the currentIndex.
Description of the change
Set currentIndex after the model change is completed
When setting the model, the list view will first emit the countChanged signal, then will change the currentIndex to 0 (see QtDeclarative git commit 22c6873 and https:/
If we set the currentIndex in the onCountChanged handler (as we were doing
before), the currentIndex would be reset to 0 shortly afterwards.
For some mysterious reason, the desired delegate was anyway shown until the bugfix for bug 1433442 was introduced; with that bugfix, the listview is more consistent and shows the delegate corresponding to the currentIndex.
* Are there any related MPs required for this MP to build/function as expected?
No, although this change is mostly relevant when using libqt5quick5 from silo 29 (because without this change, that silo would cause a regression).
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.
* Did you make sure that your branch does not contain spurious tags?
Yes.
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
It isn't.
* If you changed the UI, has there been a design review?
No visible UI changes.
FAILED: Continuous integration, rev:1917 jenkins. qa.ubuntu. com/job/ unity8- ci/6196/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- wily-touch/ 546/console jenkins. qa.ubuntu. com/job/ unity-phablet- qmluitests- wily/226/ console jenkins. qa.ubuntu. com/job/ unity8- wily-amd64- ci/435/ console jenkins. qa.ubuntu. com/job/ unity8- wily-i386- ci/436/ console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- wily-armhf/ 546/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity8- ci/6196/ rebuild
http://