Merge lp:~mardy/unity-webapps-qml/qmltypes into lp:unity-webapps-qml

Proposed by Alberto Mardegan
Status: Needs review
Proposed branch: lp:~mardy/unity-webapps-qml/qmltypes
Merge into: lp:unity-webapps-qml
Diff against target: 52 lines (+14/-4)
3 files modified
debian/control (+2/-0)
src/Ubuntu/UnityWebApps/plugin/plugin.pro (+8/-1)
src/Ubuntu/UnityWebApps/qmldir.in (+4/-3)
To merge this branch: bzr merge lp:~mardy/unity-webapps-qml/qmltypes
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Pending
WebApps Pending
Review via email: mp+295307@code.launchpad.net

Description of the change

Generate and ship typeinfo for the QML module.

To post a comment you must log in.
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

LGTM

Unmerged revisions

161. By Alberto Mardegan

Fix qmlplugindump invocation and add deps

160. By Olivier Tilloy

Generate and ship typeinfo for the QML module.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2015-03-04 17:00:45 +0000
3+++ debian/control 2016-05-20 12:28:43 +0000
4@@ -14,10 +14,12 @@
5 pkg-config,
6 python (>= 2.7),
7 python-setuptools,
8+ qml-module-ubuntu-components,
9 qt5-default,
10 qt5-qmake,
11 qtbase5-dev,
12 qtdeclarative5-dev,
13+ qtdeclarative5-dev-tools,
14 qtdeclarative5-test-plugin,
15 Standards-Version: 3.9.5
16 Homepage: https://launchpad.net/unity-webapp-qml
17
18=== modified file 'src/Ubuntu/UnityWebApps/plugin/plugin.pro'
19--- src/Ubuntu/UnityWebApps/plugin/plugin.pro 2015-02-23 15:46:02 +0000
20+++ src/Ubuntu/UnityWebApps/plugin/plugin.pro 2016-05-20 12:28:43 +0000
21@@ -66,9 +66,16 @@
22 DEFINES += \
23 API_URI=\\\"$${API_URI}\\\"
24
25+QMLTYPES_FILE = $${TARGET}.qmltypes
26+QMAKE_POST_LINK = qmlplugindump -v -noinstantiate $$API_URI $$PROJECT_VERSION ../../.. > ../$$QMLTYPES_FILE
27+
28 # plugin deployment
29 PLUGIN_INSTALL_PATH = $$[QT_INSTALL_QML]/$$replace(API_URI, \\., /)
30 target.path = $${PLUGIN_INSTALL_PATH}
31
32-INSTALLS += target
33+qmltypes_file.path = $$PLUGIN_INSTALL_PATH
34+qmltypes_file.files = ../$$QMLTYPES_FILE
35+qmltypes_file.CONFIG = no_check_exist
36+
37+INSTALLS += target qmltypes_file
38
39
40=== modified file 'src/Ubuntu/UnityWebApps/qmldir.in'
41--- src/Ubuntu/UnityWebApps/qmldir.in 2013-05-29 15:03:32 +0000
42+++ src/Ubuntu/UnityWebApps/qmldir.in 2016-05-20 12:28:43 +0000
43@@ -1,5 +1,6 @@
44 module $${API_URI}
45 plugin $${TARGET}
46-$${TARGET}Js 0.1 $${TARGET}.js
47-$${TARGET}Utils 0.1 $${TARGET}Utils.js
48-$${TARGET} 0.1 $${TARGET}.qml
49+typeinfo $${TARGET}.qmltypes
50+$${TARGET}Js $${PROJECT_VERSION} $${TARGET}.js
51+$${TARGET}Utils $${PROJECT_VERSION} $${TARGET}Utils.js
52+$${TARGET} $${PROJECT_VERSION} $${TARGET}.qml

Subscribers

People subscribed via source and target branches

to all changes: