Merge lp:~mardy/unity-2d/l10n-comment into lp:unity-2d

Proposed by Alberto Mardegan on 2011-10-05
Status: Merged
Approved by: Michał Sawicz on 2011-10-10
Approved revision: 751
Merged at revision: 750
Proposed branch: lp:~mardy/unity-2d/l10n-comment
Merge into: lp:unity-2d
Diff against target: 25 lines (+4/-0)
2 files modified
libunity-2d-private/src/unity2dapplication.cpp (+3/-0)
po/update-unity-2d-pot (+1/-0)
To merge this branch: bzr merge lp:~mardy/unity-2d/l10n-comment
Reviewer Review Type Date Requested Status
Michał Sawicz 2011-10-05 Approve on 2011-10-10
Review via email: mp+78245@code.launchpad.net

Description of the change

[lib] Add translators comment for QT_LAYOUT_DIRECTION

To post a comment you must log in.
Michał Sawicz (saviq) wrote :

I don't think there's a need to mention "QT_LAYOUT_DIRECTION" in the comment, since it's going to be bound with that msgid anyway.

review: Needs Fixing
Alberto Mardegan (mardy) wrote :

Updated.

lp:~mardy/unity-2d/l10n-comment updated on 2011-10-10
751. By Alberto Mardegan on 2011-10-10

Adjusted comment.

Michał Sawicz (saviq) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libunity-2d-private/src/unity2dapplication.cpp'
2--- libunity-2d-private/src/unity2dapplication.cpp 2011-09-20 08:40:43 +0000
3+++ libunity-2d-private/src/unity2dapplication.cpp 2011-10-10 11:10:28 +0000
4@@ -148,6 +148,9 @@
5 {
6 /* Configure translations */
7 Unity2dTr::init("unity-2d", INSTALL_PREFIX "/share/locale");
8+
9+ /* TRANSLATORS: This refers to the direction of text
10+ (left-to-right or right-to-left): possible values are LTR or RTL */
11 if (u2dTr("QT_LAYOUT_DIRECTION") == "RTL") {
12 QApplication::setLayoutDirection(Qt::RightToLeft);
13 }
14
15=== modified file 'po/update-unity-2d-pot'
16--- po/update-unity-2d-pot 2011-03-16 17:18:20 +0000
17+++ po/update-unity-2d-pot 2011-10-10 11:10:28 +0000
18@@ -20,6 +20,7 @@
19 --output $PO_DIR/unity-2d.pot \
20 --files-from $GETTEXT_FILES \
21 --qt --c++ \
22+ --add-comments=TRANSLATORS \
23 --keyword=u2dTr:1,1t --keyword=u2dTr:1,2,3t \
24 --keyword=tr:1,1t --keyword=tr:1,2,3t \
25 --package-name unity-2d \

Subscribers

People subscribed via source and target branches