Merge lp:~mardy/unity-2d/grid-flow into lp:unity-2d
Status: | Merged |
---|---|
Approved by: | Gerry Boland |
Approved revision: | 696 |
Merged at revision: | 738 |
Proposed branch: | lp:~mardy/unity-2d/grid-flow |
Merge into: | lp:unity-2d |
Diff against target: |
70 lines (+31/-6) 2 files modified
places/CenteredGridView.qml (+9/-0) places/ListViewWithHeaders.qml (+22/-6) |
To merge this branch: | bzr merge lp:~mardy/unity-2d/grid-flow |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michał Sawicz | functional | Approve | |
Gerry Boland (community) | Approve | ||
Florian Boucault (community) | functional | Approve | |
Alberto Mardegan (community) | Abstain | ||
Review via email: mp+74232@code.launchpad.net |
Commit message
[dash] Set height on lenses results containers
Setting the proper height prevents drawing outside the container area.
This patch also renames a few variables, and hopefully improves code
readability.
Description of the change
[dash] Set height on lenses results containers
Setting the proper height prevents drawing outside the container area.
This patch also renames a few variables, and hopefully improves code
readability.
In order to ease the testing and understanding of what this patch does, you can add the following code
==========
==========
inside the "bodyLoader" item, right after this line:
If you run the dash with this code, before and after applying the MR, you'll see how the bodyLoader element size is computed.
Hey Alberto,
I'm testing this now (note: on Qt4.7.4 which we'll be using) and I am still seeing layout problems. Try this:
1. Open Dash, select the Applications lens. The Filter pane is open.
2. All 3 groups are collapsed. I click on the "Installed" header to show all the installed apps.
3. Scroll down to the very bottom of the list.
4. Click "Filter results" to hide the filter pane.
5. Click it again to show the filter pane. The list pops up a bit.
6. Try scrolling down to the bottom of the list again.
I see a big blank area for a while, and then the list just re-appears correctly. I can make you a video of this if you like.