lp:~mardy/ubuntu-system-settings-online-accounts/signon-ui-service

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~mardy/ubuntu-system-settings-online-accounts/master at revision 122

Sebastien Bacher (community): Approve on 2014-06-04

Alberto Mardegan: Pending requested 2014-06-04

Diff: 91 lines (+7/-15)

7 files modified

.bzrignore (+0/-1)
debian/changelog (+6/-0)
debian/control (+1/-2)
debian/ubuntu-system-settings-online-accounts.install (+0/-2)
src/com.canonical.indicators.webcredentials.service.in (+0/-3)
src/com.nokia.singlesignonui.service.in (+0/-3)
src/online-accounts-ui.pro (+0/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

125. By Alberto Mardegan on 2014-06-13

Remove signon-ui provides

124. By Alberto Mardegan on 2014-06-04

Move service to signon-ui

123. By Alberto Mardegan on 2014-06-04

Fix

122. By Alberto Mardegan on 2014-06-04

Add signon-ui-service, to fix co-installation of signon-ui.

121. By Alberto Mardegan on 2014-06-02

Merge from trunk

[ CI bot ]
* Release development branch Features landing with this branch:
  Updating the ACL when applications are enabled/disabled in System
  Settings. Write profile information in the XML files installed by
  click hooks. Run tests with Python 3 autopilot. Merge signon-ui into
  online-accounts-ui .
[ Alberto Mardegan ]
* Release development branch Features landing with this branch:
  Updating the ACL when applications are enabled/disabled in System
  Settings. Write profile information in the XML files installed by
  click hooks. Run tests with Python 3 autopilot. Merge signon-ui into
  online-accounts-ui .

120. By Alberto Mardegan on 2014-05-30

When processing completes, raise the caller application

Under unity8, use QDesktopServices to raise the application which invoked OA. Also, avoid queuing requests to open OA from the System Settings.

119. By Alberto Mardegan on 2014-05-30

Use the new header design

118. By Alberto Mardegan on 2014-05-30

Fix QQmlExpression's invalid context warning

The bug was caused because we are destroying the page while the Ubuntu UI toolkit is still playing the fading out animation for the dialog which prompts for the removal confirmation.
The fix consists of emitting the closed() signal (and therefore proceed with the removal of the account) only after the dialog animation has been completed.
This is a sequential animation, whose last step is setting the "visible" property to false.

117. By Alberto Mardegan on 2014-05-28

Merge signon-ui into online-accounts-ui

This copies the implementation of the D-Bus com.nokia.singlesignonui service which is currently implemented in the signon-ui process (lp:signon-ui) into online-accounts-ui.
The com.nokia.singlesignonui interface is invoked by signond when a user interaction is required, for instance for asking a password or login into a site supporting OAuth.
By merging the functionality into online-accounts-ui we eliminate the complexity of reparenting or embedding windows (on the desktop, the Online Accounts panel is using XEMBED to show the UI coming from signon-ui).
Most of the code is coming straight from signon-ui:

signon-ui -> online-accounts-ui
src/service.{h,cpp} -> src/signonui-service.{h,cpp}
src/request.{h,cpp} -> src/signonui-request.{h,cpp}
src/ubuntu-browser-request.{h,cpp} -> src/browser-request.{h,cpp}
src/reauthenticator.{h,cpp} -> src/reauthenticator.{h,cpp}
src/indicator-service.{h,cpp} -> src/indicator-service.{h,cpp}
src/qquick-dialog.{h,cpp} -> src/dialog.{h,cpp}
src/qml/KeyboardRectangle.qml -> src/module/KeyboardRectangle.qml
src/qml/StandardAnimation.qml -> src/module/StandardAnimation.qml
src/qml/WebView.qml -> src/module/WebView.qml

with a couple of notable exceptions:

- since src/signonui-service.cpp and src/service.cpp follow a very similar logic, a new src/request-manager.{h,cpp} class has been created to collect the common functionality.

- a new RequestHandler QML class has been created (src/request-handler.{h,cpp}); account-plugins use this element (in src/module/OAuth.qml) to inform online-accounts-ui that the UI request will be handled by the plugin itself, and that online-accounts-ui must not queue it or create additional windows for it.

In the same fashion, the implementation of the D-Bus service com.canonical.indicators.webcredentials is also transplanted here. This is a simple interface which is used to query the general status of Online Accounts, that is the list of accounts needing to be reauthenticated (if any). On the desktop, this is currently used by the Online Accounts panel in the Unity Control Center and by the "Online Accounts" indicator which appears in the system menu when accounts need to be re-authenticated.
It's not clear yet how this interface will be used on the phone, but it will eventually be used.

116. By Alberto Mardegan on 2014-05-28

Run tests with Python 3 autopilot.