Merge lp:~mardy/ubuntu-system-settings-online-accounts/lp1440034 into lp:ubuntu-system-settings-online-accounts

Proposed by Alberto Mardegan
Status: Merged
Approved by: David Barth
Approved revision: 250
Merged at revision: 252
Proposed branch: lp:~mardy/ubuntu-system-settings-online-accounts/lp1440034
Merge into: lp:ubuntu-system-settings-online-accounts
Diff against target: 11 lines (+1/-0)
1 file modified
online-accounts-ui/browser-request.cpp (+1/-0)
To merge this branch: bzr merge lp:~mardy/ubuntu-system-settings-online-accounts/lp1440034
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Online Accounts Pending
Review via email: mp+255178@code.launchpad.net

Commit message

Flush writes to the JSON cookie file before telling to online-accounts-service that we are ready. Otherwise there is the risk of having online-accounts-service read that file before it has been written.

Description of the change

Flush writes to the JSON cookie file before telling to online-accounts-service that we are ready. Otherwise there is the risk of having online-accounts-service read that file before it has been written.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'online-accounts-ui/browser-request.cpp'
2--- online-accounts-ui/browser-request.cpp 2015-02-20 16:08:12 +0000
3+++ online-accounts-ui/browser-request.cpp 2015-04-03 11:41:07 +0000
4@@ -212,6 +212,7 @@
5 if (Q_LIKELY(file.open(QIODevice::WriteOnly | QIODevice::Text))) {
6 QJsonDocument doc(jsonCookies);
7 file.write(doc.toJson());
8+ file.close();
9 }
10
11 onFinished();

Subscribers

People subscribed via source and target branches