Merge lp:~mardy/ubuntu-system-settings-online-accounts/lp1315341 into lp:~mardy/ubuntu-system-settings-online-accounts/master
Status: | Merged |
---|---|
Approved by: | Alberto Mardegan |
Approved revision: | 112 |
Merged at revision: | 118 |
Proposed branch: | lp:~mardy/ubuntu-system-settings-online-accounts/lp1315341 |
Merge into: | lp:~mardy/ubuntu-system-settings-online-accounts/master |
Diff against target: |
19 lines (+2/-1) 1 file modified
src/module/RemovalConfirmation.qml (+2/-1) |
To merge this branch: | bzr merge lp:~mardy/ubuntu-system-settings-online-accounts/lp1315341 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Justin McPherson (community) | Approve | ||
Alberto Mardegan | Pending | ||
Review via email:
|
Commit message
Fix QQmlExpression's invalid context warning
The bug was caused because we are destroying the page while the Ubuntu UI
toolkit is still playing the fading out animation for the dialog which prompts
for the removal confirmation.
The fix consists of emitting the closed() signal (and therefore proceed with
the removal of the account) only after the dialog animation has been completed.
This is a sequential animation, whose last step is setting the "visible"
property to false.
Description of the change
Fix QQmlExpression's invalid context warning
The bug was caused because we are destroying the page while the Ubuntu UI
toolkit is still playing the fading out animation for the dialog which prompts
for the removal confirmation.
The fix consists of emitting the closed() signal (and therefore proceed with
the removal of the account) only after the dialog animation has been completed.
This is a sequential animation, whose last step is setting the "visible"
property to false.