Merge lp:~mardy/ubuntu-system-settings-online-accounts/loading-1544063 into lp:ubuntu-system-settings-online-accounts

[Alberto Mardegan]

Don't use deprecated onLoadingChanged signal.

Don't use deprecated onLoadingChanged signal.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:329
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-ci/272/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-wily-touch/982/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-wily-amd64-ci/60/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-wily-i386-ci/60/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-wily-armhf/982/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-online-accounts-ci/272/rebuild

review: Needs Fixing (continuous-integration)

[Albert Astals Cid (aacid)]

Tried and works fine.

review: Approve

[lp:~mardy/ubuntu-system-settings-online-accounts/loading-1544063]

330. By Alberto Mardegan on 2016-02-24

Don't emit failse positives on failures

=== modified file 'plugins/module/WebView.qml'
--- plugins/module/WebView.qml	2015-11-02 07:28:44 +0000
+++ plugins/module/WebView.qml	2016-02-24 10:29:54 +0000
@@ -12,13 +12,13 @@
         url = signonRequest.startUrl
     }
 
-    onLoadingChanged: {
+    onLoadingStateChanged: {
         console.log("Loading changed")
         if (loading && !lastLoadFailed) {
             signonRequest.onLoadStarted()
         } else if (lastLoadSucceeded) {
             signonRequest.onLoadFinished(true)
-        } else {
+        } else if (lastLoadFailed) {
             signonRequest.onLoadFinished(false)
         }
     }