Merge lp:~mardy/ubuntu-system-settings-online-accounts/invalid-provider-1554254 into lp:ubuntu-system-settings-online-accounts

[Alberto Mardegan]

Don't crash on invalid providers

Don't crash on invalid providers

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:332
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-ci/287/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-wily-touch/998/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-wily-amd64-ci/75/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-wily-i386-ci/75/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-wily-armhf/998/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-online-accounts-ci/287/rebuild

review: Needs Fixing (continuous-integration)

=== modified file 'plugins/OnlineAccountsPlugin/application-manager.cpp'
--- plugins/OnlineAccountsPlugin/application-manager.cpp	2015-09-24 12:58:34 +0000
+++ plugins/OnlineAccountsPlugin/application-manager.cpp	2016-03-08 08:05:08 +0000
@@ -188,6 +188,10 @@
 {
     Accounts::Provider provider =
         AccountManager::instance()->provider(providerId);
+    if (Q_UNLIKELY(!provider.isValid())) {
+        qWarning() << "Invalid provider" << providerId;
+        return QVariantMap();
+    }
 
     QVariantMap info;
     info.insert(QStringLiteral("id"), providerId);