Merge lp:~mardy/ubuntu-system-settings-online-accounts/handle-errors-1349975 into lp:ubuntu-system-settings-online-accounts
Proposed by
Alberto Mardegan
Status: | Merged |
---|---|
Approved by: | David Barth |
Approved revision: | 302 |
Merged at revision: | 306 |
Proposed branch: | lp:~mardy/ubuntu-system-settings-online-accounts/handle-errors-1349975 |
Merge into: | lp:ubuntu-system-settings-online-accounts |
Diff against target: |
208 lines (+81/-10) 8 files modified
debian/control (+2/-2) online-accounts-ui/browser-request.cpp (+8/-2) online-accounts-ui/qml/ProviderRequest.qml (+0/-2) plugins/module/ErrorItem.qml (+48/-0) plugins/module/OAuth.qml (+20/-2) plugins/module/WebView.qml (+1/-1) plugins/module/module.pro (+1/-0) tests/online-accounts-ui/tst_browser_request.cpp (+1/-1) |
To merge this branch: | bzr merge lp:~mardy/ubuntu-system-settings-online-accounts/handle-errors-1349975 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Online Accounts | Pending | ||
Review via email:
|
Commit message
Retry authentication on network errors
If the authentication fails because of a network error, show an error screen
and let the user retry the authentication from within the plugin.
This requires the BrowserRequest to emit the proper error code, and not cancel
the tiemout failure timer if the current page URL is visited again.
Description of the change
Retry authentication on network errors
If the authentication fails because of a network error, show an error screen
and let the user retry the authentication from within the plugin.
This requires the BrowserRequest to emit the proper error code, and not cancel
the tiemout failure timer if the current page URL is visited again.
To post a comment you must log in.
FAILED: Continuous integration, rev:298 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- online- accounts- ci/256/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- wily-touch/ 764/console jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- online- accounts- wily-amd64- ci/44/console jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- online- accounts- wily-i386- ci/44/console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- wily-armhf/ 764/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- system- settings- online- accounts- ci/256/ rebuild
http://