Merge lp:~mardy/ubuntu-system-settings-online-accounts/fix-auth-with-params into lp:ubuntu-system-settings-online-accounts

Proposed by Alberto Mardegan on 2013-10-16
Status: Merged
Approved by: Ken VanDine on 2013-10-16
Approved revision: 69
Merged at revision: 69
Proposed branch: lp:~mardy/ubuntu-system-settings-online-accounts/fix-auth-with-params
Merge into: lp:ubuntu-system-settings-online-accounts
Diff against target: 12 lines (+1/-1)
1 file modified
src/module/OAuth.qml (+1/-1)
To merge this branch: bzr merge lp:~mardy/ubuntu-system-settings-online-accounts/fix-auth-with-params
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve on 2013-10-16
Ken VanDine 2013-10-16 Approve on 2013-10-16
Review via email: mp+191405@code.launchpad.net

Commit message

Fix OAuth authentication with parameters

Fix an obvious JS error.

Description of the change

Fix OAuth authentication with parameters

Fix an obvious JS error.

To post a comment you must log in.
Ken VanDine (ken-vandine) wrote :

Obvious fix

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/module/OAuth.qml'
2--- src/module/OAuth.qml 2013-10-09 21:56:30 +0000
3+++ src/module/OAuth.qml 2013-10-16 13:28:27 +0000
4@@ -136,7 +136,7 @@
5 var parameters = {
6 "X-PageComponent": "file:///usr/share/signon-ui/online-accounts-ui/Page.qml"
7 }
8- for (p in authenticationParameters) {
9+ for (var p in authenticationParameters) {
10 parameters[p] = authenticationParameters[p]
11 }
12 __isAuthenticating = true

Subscribers

People subscribed via source and target branches