Merge lp:~mardy/signon-ui/signon-ui-service into lp:~online-accounts/signon-ui/master

Proposed by Alberto Mardegan
Status: Merged
Merged at revision: 132
Proposed branch: lp:~mardy/signon-ui/signon-ui-service
Merge into: lp:~online-accounts/signon-ui/master
Diff against target: 125 lines (+24/-12)
9 files modified
.bzrignore (+3/-1)
debian/changelog (+3/-2)
debian/control (+14/-1)
debian/signon-ui-service.install (+2/-0)
debian/signon-ui-x11.install (+2/-0)
src/com.canonical.indicators.webcredentials.service.in (+0/-3)
src/com.nokia.singlesignonui.service.in (+0/-3)
tests/unit/tst_inactivity_timer.pro (+0/-1)
tests/unit/tst_signon_ui.pro (+0/-1)
To merge this branch: bzr merge lp:~mardy/signon-ui/signon-ui-service
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
Online Accounts Pending
Review via email: mp+222017@code.launchpad.net

Commit message

Add signon-ui-service, to fix co-installation with u-s-s-o-a

Add also debian .install files for signon-ui, and make sure that unit tests are not installed.

Description of the change

Add signon-ui-service, to fix co-installation with u-s-s-o-a

Add also debian .install files for signon-ui, and make sure that unit tests are not installed.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

If you rename signon-ui to signon-ui-x11 you want to use Conflicts/Replaces/Provides without versions. You also should build the service from signon-ui since it's in main and u-s-s-o-a is in universe

review: Needs Fixing
133. By Alberto Mardegan

Add signon-ui-service, do not install tests

Revision history for this message
Sebastien Bacher (seb128) wrote :

Looks good to me, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.bzrignore'
2--- .bzrignore 2014-04-22 14:08:45 +0000
3+++ .bzrignore 2014-06-04 12:05:33 +0000
4@@ -14,7 +14,9 @@
5 builddir
6 core
7 /debian/files
8-/debian/signon-ui
9+/debian/signon-ui-service
10+/debian/signon-ui-x11
11+/debian/tmp
12 Makefile
13 Makefile.*
14 moc_*
15
16=== modified file 'debian/changelog'
17--- debian/changelog 2014-05-09 11:00:40 +0000
18+++ debian/changelog 2014-06-04 12:05:33 +0000
19@@ -1,8 +1,9 @@
20-signon-ui (0.16+14.04.20140505-0ubuntu1) UNRELEASED; urgency=medium
21+signon-ui (0.17-0ubuntu1) UNRELEASED; urgency=medium
22
23 * Use Oxide instead of WebKit2
24+ * Use signon-ui-service, to fix co-installation with u-s-s-o-a
25
26- -- Alberto Mardegan <alberto.mardegan@canonical.com> Tue, 06 May 2014 14:52:52 +0300
27+ -- Alberto Mardegan <alberto.mardegan@canonical.com> Wed, 04 Jun 2014 12:34:30 +0300
28
29 signon-ui (0.16+14.04.20140304.is.0.15+14.04.20140313-0ubuntu2) utopic; urgency=medium
30
31
32=== modified file 'debian/control'
33--- debian/control 2014-04-29 19:06:14 +0000
34+++ debian/control 2014-06-04 12:05:33 +0000
35@@ -33,9 +33,22 @@
36 # just go ahead. ~online-accounts will notice and sync up the code again.
37 Vcs-Bzr: https://code.launchpad.net/~online-accounts/signon-ui/trunk
38
39-Package: signon-ui
40+Package: signon-ui-x11
41 Architecture: any
42 Depends: ${misc:Depends},
43 ${shlibs:Depends},
44+ signon-ui-service
45+Conflicts: signon-ui
46+Replaces: signon-ui
47+Provides: signon-ui
48 Description: Single Sign-on UI
49 UI for the signond Single Signon service
50+
51+Package: signon-ui-service
52+Architecture: all
53+Multi-Arch: foreign
54+Depends: ${misc:Depends}
55+Breaks: signon-ui (<< 0.17), ubuntu-system-settings-online-accounts (<< 0.4)
56+Replaces: signon-ui (<< 0.17), ubuntu-system-settings-online-accounts (<< 0.4)
57+Description: D-Bus service file for signon-ui
58+ This D-Bus service is used to provide a UI for authenticating online accounts.
59
60=== added file 'debian/signon-ui-service.install'
61--- debian/signon-ui-service.install 1970-01-01 00:00:00 +0000
62+++ debian/signon-ui-service.install 2014-06-04 12:05:33 +0000
63@@ -0,0 +1,2 @@
64+usr/share/dbus-1/services/com.canonical.indicators.webcredentials.service
65+usr/share/dbus-1/services/com.nokia.singlesignonui.service
66
67=== added file 'debian/signon-ui-x11.install'
68--- debian/signon-ui-x11.install 1970-01-01 00:00:00 +0000
69+++ debian/signon-ui-x11.install 2014-06-04 12:05:33 +0000
70@@ -0,0 +1,2 @@
71+usr/bin/signon-ui
72+usr/share/applications/signon-ui.desktop
73
74=== added file 'src/com.canonical.indicators.webcredentials.service.in'
75--- src/com.canonical.indicators.webcredentials.service.in 1970-01-01 00:00:00 +0000
76+++ src/com.canonical.indicators.webcredentials.service.in 2014-06-04 12:05:33 +0000
77@@ -0,0 +1,3 @@
78+[D-BUS Service]
79+Name=com.canonical.indicators.webcredentials
80+Exec=/bin/sh -c "'if [ ! -x $${target.path}/$${TARGET} ] || [ \"$QT_QPA_PLATFORM\" = \"ubuntumirclient\" ]; then exec /usr/bin/online-accounts-ui --desktop_file_hint=/usr/share/applications/online-accounts-ui.desktop; else exec $${target.path}/$${TARGET}; fi'"
81
82=== removed file 'src/com.canonical.indicators.webcredentials.service.in'
83--- src/com.canonical.indicators.webcredentials.service.in 2013-06-10 11:04:32 +0000
84+++ src/com.canonical.indicators.webcredentials.service.in 1970-01-01 00:00:00 +0000
85@@ -1,3 +0,0 @@
86-[D-BUS Service]
87-Name=com.canonical.indicators.webcredentials
88-Exec=$${INSTALL_PREFIX}/bin/signon-ui
89
90=== added file 'src/com.nokia.singlesignonui.service.in'
91--- src/com.nokia.singlesignonui.service.in 1970-01-01 00:00:00 +0000
92+++ src/com.nokia.singlesignonui.service.in 2014-06-04 12:05:33 +0000
93@@ -0,0 +1,3 @@
94+[D-BUS Service]
95+Name=com.nokia.singlesignonui
96+Exec=/bin/sh -c "'if [ ! -x $${target.path}/$${TARGET} ] || [ \"$QT_QPA_PLATFORM\" = \"ubuntumirclient\" ]; then exec /usr/bin/online-accounts-ui --desktop_file_hint=/usr/share/applications/online-accounts-ui.desktop; else exec $${target.path}/$${TARGET}; fi'"
97
98=== removed file 'src/com.nokia.singlesignonui.service.in'
99--- src/com.nokia.singlesignonui.service.in 2014-04-23 08:10:39 +0000
100+++ src/com.nokia.singlesignonui.service.in 1970-01-01 00:00:00 +0000
101@@ -1,3 +0,0 @@
102-[D-BUS Service]
103-Name=com.nokia.singlesignonui
104-Exec=$${INSTALL_PREFIX}/bin/signon-ui$${COMMANDLINE}
105
106=== modified file 'tests/unit/tst_inactivity_timer.pro'
107--- tests/unit/tst_inactivity_timer.pro 2013-03-14 13:19:02 +0000
108+++ tests/unit/tst_inactivity_timer.pro 2014-06-04 12:05:33 +0000
109@@ -1,6 +1,5 @@
110 include(../../common-project-config.pri)
111 include($${TOP_SRC_DIR}/common-vars.pri)
112-include($${TOP_SRC_DIR}/common-installs-config.pri)
113
114 TARGET = tst_inactivity_timer
115
116
117=== modified file 'tests/unit/tst_signon_ui.pro'
118--- tests/unit/tst_signon_ui.pro 2013-06-17 11:21:13 +0000
119+++ tests/unit/tst_signon_ui.pro 2014-06-04 12:05:33 +0000
120@@ -1,6 +1,5 @@
121 include(../../common-project-config.pri)
122 include($${TOP_SRC_DIR}/common-vars.pri)
123-include($${TOP_SRC_DIR}/common-installs-config.pri)
124
125 TARGET = signon-ui-unittest
126

Subscribers

People subscribed via source and target branches