Online Accounts: Sign-on UI

Merge lp:~mardy/signon-ui/lp1238485 into lp:signon-ui

  1. lp1238485
  2. Merge into trunk
Proposed by Alberto Mardegan
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 116
Merged at revision: 116
Proposed branch: lp:~mardy/signon-ui/lp1238485
Merge into: lp:signon-ui
Diff against target: 16 lines (+2/-4)
1 file modified
src/browser-process/DefaultPage.qml (+2/-4)
To merge this branch: bzr merge lp:~mardy/signon-ui/lp1238485
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Online Accounts Pending
Review via email: mp+190544@code.launchpad.net

Commit message

Do not anchor to the osk item (OnScreenKeyboard), as it's not a sibling.

Description of the change

Do not anchor to the osk item (OnScreenKeyboard), as it's not a sibling.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:116
http://jenkins.qa.ubuntu.com/job/signon-ui-ci/40/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/signon-ui-saucy-amd64-ci/20

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/signon-ui-ci/40/rebuild

review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

that seems logical

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/browser-process/DefaultPage.qml'
2--- src/browser-process/DefaultPage.qml 2013-10-08 14:49:13 +0000
3+++ src/browser-process/DefaultPage.qml 2013-10-11 07:25:11 +0000
4@@ -5,10 +5,8 @@
5 Loader {
6 id: loader
7 anchors {
8- top: parent.top
9- left: parent.left
10- right: parent.right
11- bottom: osk.top
12+ fill: parent
13+ bottomMargin: osk.height
14 }
15 focus: true
16 sourceComponent: browserComponent

Subscribers

People subscribed via source and target branches

to all changes: