Merge lp:~mardy/signon-ui/lp1217792 into lp:signon-ui

Proposed by Alberto Mardegan
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 108
Merged at revision: 108
Proposed branch: lp:~mardy/signon-ui/lp1217792
Merge into: lp:signon-ui
Diff against target: 11 lines (+1/-0)
1 file modified
src/browser-process/webview.qml (+1/-0)
To merge this branch: bzr merge lp:~mardy/signon-ui/lp1217792
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Víctor R. Ruiz (community) Approve
Review via email: mp+188552@code.launchpad.net

Commit message

Add missing import line

The lack of this line was causing the "units.gu()" function to be undefined,
and therefore the form factor was undefined as well, and consequently also the
user-agent.

Description of the change

Add missing import line

The lack of this line was causing the "units.gu()" function to be undefined,
and therefore the form factor was undefined as well, and consequently also the
user-agent.

To post a comment you must log in.
Revision history for this message
Víctor R. Ruiz (vrruiz) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:108
http://jenkins.qa.ubuntu.com/job/signon-ui-ci/29/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/signon-ui-saucy-amd64-ci/9/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/signon-ui-ci/29/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/signon-ui-autolanding/16/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/signon-ui-saucy-amd64-autolanding/6/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:108
http://jenkins.qa.ubuntu.com/job/signon-ui-ci/30/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/signon-ui-saucy-amd64-ci/10/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/signon-ui-ci/30/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/browser-process/webview.qml'
2--- src/browser-process/webview.qml 2013-06-03 16:23:07 +0000
3+++ src/browser-process/webview.qml 2013-10-01 11:06:16 +0000
4@@ -2,6 +2,7 @@
5 import QtQuick.Window 2.0
6 import QtWebKit 3.0
7 import QtWebKit.experimental 1.0
8+import Ubuntu.Components 0.1
9
10 FocusScope {
11 id: browser

Subscribers

People subscribed via source and target branches

to all changes: