lp:~mardy/signon-ui/local-interface

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:signon-ui at revision 65

David King (community): Approve on 2012-09-24

jenkins (community): Needs Fixing (continuous-integration) on 2012-09-24

Diff: 27 lines (+5/-3)

2 files modified

src/request.cpp (+4/-1)
src/webcredentials_interface.cpp (+1/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1040580: signon-ui assert failure: *** glibc detected *** /usr/bin/signon-ui: invalid fastbin entry (free): 0x000000000234c3c0 ***

High

Fix Released

Link a bug report

Related blueprints

64. By Alberto Mardegan on 2012-09-24

Do not istantiate invalid QDBusMessages

QDBus does not allow creating replies out of invalid messages: there's a
Q_ASSERT for that inside the Qt code, which luckily isn't met because Qt is
built with assertions disabled.
Still, we were running into undefined behaviour.

63. By Alberto Mardegan on 2012-09-18

Version 0.10

62. By Alberto Mardegan on 2012-09-17

Coverage support

61. By Alberto Mardegan on 2012-09-17

Use libproxy to detect proxy settings

60. By Alberto Mardegan on 2012-09-14

Don't emit an OSD notification when accounts fail to authenticate

59. By Alberto Mardegan on 2012-09-12

Version 0.9

58. By Alberto Mardegan on 2012-09-12

Ignore any webview signals since the authentication is completed

This is needed because QWebView might still emit loadFinished(false)
(which we would interpret as an error) on the final URL, which we don't
care about anymore.

57. By Alberto Mardegan on 2012-09-12

Early terminate successful requests with no UI

As for the embedded case, we can early terminate (by calling accept() on the
dialog) successful requests when the dialog has not been shown. This prevents
from any other processing which could bring the request on an error state.

56. By Alberto Mardegan on 2012-09-10

Version 0.8

55. By Alberto Mardegan on 2012-09-10

Avoid loading the final URL.

Successfully terminate the browser request as soon as we are requested to
navigate to the final URL, without even attempting to load it.