Ubuntu Online Accounts API

Merge lp:~mardy/online-accounts-api/daemon-coverage into lp:online-accounts-api

  1. daemon-coverage
  2. Merge into trunk
Proposed by Alberto Mardegan on 2016-07-20
Status: Merged
Approved by: James Henstridge on 2016-08-04
Approved revision: 22
Merged at revision: 25
Proposed branch: lp:~mardy/online-accounts-api/daemon-coverage
Merge into: lp:online-accounts-api
Diff against target: 10 lines (+1/-1)
1 file modified
CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~mardy/online-accounts-api/daemon-coverage
Reviewer Review Type Date Requested Status
James Henstridge 2016-07-20 Approve on 2016-08-04
Review via email: mp+300593@code.launchpad.net

Commit Message

Enable coverage reporting for the OnlineAccountsDaemon library

This was probably lost when the daemon was turned into a library.

Description of the Change

Enable coverage reporting for the OnlineAccountsDaemon library

This was probably lost when the daemon was turned into a library.

To post a comment you must log in.
James Henstridge (jamesh) wrote :

Looks great!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2015-08-28 14:25:23 +0000
3+++ CMakeLists.txt 2016-07-20 13:15:54 +0000
4@@ -41,6 +41,6 @@
5
6 include(EnableCoverageReport)
7 if(cmake_build_type_lower MATCHES coverage)
8- ENABLE_COVERAGE_REPORT(TARGETS OnlineAccountsQt OnlineAccountsQML accountd FILTER /usr/include ${CMAKE_SOURCE_DIR}/tests/* ${CMAKE_BINARY_DIR}/*)
9+ ENABLE_COVERAGE_REPORT(TARGETS OnlineAccountsDaemon OnlineAccountsQt OnlineAccountsQML accountd FILTER /usr/include ${CMAKE_SOURCE_DIR}/tests/* ${CMAKE_BINARY_DIR}/*)
10 endif()
11

Subscribers

People subscribed via source and target branches