Merge lp:~mardy/account-plugins/remove-scripts into lp:account-plugins

Proposed by Alberto Mardegan
Status: Merged
Approved by: David King
Approved revision: 67
Merged at revision: 67
Proposed branch: lp:~mardy/account-plugins/remove-scripts
Merge into: lp:account-plugins
Diff against target: 97 lines (+1/-68)
5 files modified
tools/Makefile.am (+1/-3)
tools/facebook-login.sh (+0/-11)
tools/facebook.sh (+0/-28)
tools/google-login.sh (+0/-10)
tools/google.sh (+0/-16)
To merge this branch: bzr merge lp:~mardy/account-plugins/remove-scripts
Reviewer Review Type Date Requested Status
David King (community) Approve
Review via email: mp+123545@code.launchpad.net

Description of the change

Remove Google and Facebook account creation scripts

These scripts are not needed anymore, and probably obsolete anyway.

To post a comment you must log in.
Revision history for this message
David King (amigadave) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tools/Makefile.am'
2--- tools/Makefile.am 2012-01-10 10:31:22 +0000
3+++ tools/Makefile.am 2012-09-10 13:28:55 +0000
4@@ -1,7 +1,5 @@
5 bin_SCRIPTS = \
6- account-console \
7- facebook.sh \
8- google.sh
9+ account-console
10
11 EXTRA_DIST = \
12 $(bin_SCRIPTS)
13
14=== removed file 'tools/facebook-login.sh'
15--- tools/facebook-login.sh 2012-05-02 22:58:46 +0000
16+++ tools/facebook-login.sh 1970-01-01 00:00:00 +0000
17@@ -1,11 +0,0 @@
18-#! /bin/bash
19-
20-IDENTITY="$1"
21-shift
22-./account-console signon_login "$IDENTITY" oauth2 user_agent \
23- -p Host=www.facebook.com \
24- -p AuthPath=dialog/oauth \
25- -p RedirectUri=https://www.facebook.com/connect/login_success.html \
26- -p ClientId=213156715390803 \
27- -p Display=popup "$@"
28-
29
30=== removed file 'tools/facebook.sh'
31--- tools/facebook.sh 2012-01-05 11:40:40 +0000
32+++ tools/facebook.sh 1970-01-01 00:00:00 +0000
33@@ -1,28 +0,0 @@
34-#! /bin/bash
35-
36-set -e
37-
38-USERNAME="$1"
39-
40-CREATION_PARAMS=('--print-id' \
41- -s 'auth/oauth2/user_agent/Host=www.facebook.com' \
42- -s 'auth/oauth2/user_agent/AuthPath=/dialog/oauth' \
43- -s 'auth/oauth2/user_agent/ClientId=213156715390803' \
44- -s 'auth/oauth2/user_agent/RedirectUri=https://www.facebook.com/connect/login_success.html' \
45- -s 'auth/oauth2/user_agent/ResponseType/item0=token' \
46- -s 'auth/oauth2/user_agent/Scope/item0=offline_access' \
47- -s 'auth/oauth2/user_agent/Scope/item1=publish_stream' \
48- -s 'auth/oauth2/user_agent/Scope/item2=user_photos' \
49- -s 'auth/oauth2/user_agent/Scope/item3=user_videos' \
50- -s 'auth/oauth2/user_agent/Display=popup' \
51-)
52-
53-ID="$(./account-console create facebook ${CREATION_PARAMS[@]})"
54-./account-console edit "$ID" --username "$USERNAME"
55-
56-#./account-console login "$1" oauth2 user_agent \
57-# -p Host=www.facebook.com \
58-# -p AuthPath=/dialog/oauth \
59-# -p RedirectUri=https://www.facebook.com/connect/login_success.html \
60-# -p ClientId=213156715390803
61-
62
63=== removed file 'tools/google-login.sh'
64--- tools/google-login.sh 2012-03-01 14:16:01 +0000
65+++ tools/google-login.sh 1970-01-01 00:00:00 +0000
66@@ -1,10 +0,0 @@
67-#! /bin/bash
68-
69-./account-console signon_login "$1" oauth2 user_agent \
70- -p Host=accounts.google.com \
71- -p AuthPath=o/oauth2/auth \
72- -p RedirectUri=http://www.mardy.it/oauth2callback \
73- -p ClientId=1041829795610-htf69c529db58qcq8jvf58bijn1ie3oi.apps.googleusercontent.com \
74- -p "as:ResponseType=['token']" \
75- -p Scope=https://picasaweb.google.com/data/
76-
77
78=== removed file 'tools/google.sh'
79--- tools/google.sh 2012-01-17 12:11:08 +0000
80+++ tools/google.sh 1970-01-01 00:00:00 +0000
81@@ -1,16 +0,0 @@
82-#! /bin/bash
83-
84-set -e
85-
86-USERNAME="$1"
87-
88-CREATION_PARAMS=('--print-id' \
89- -s 'auth/oauth2/user_agent/Host=accounts.google.com' \
90- -s 'auth/oauth2/user_agent/AuthPath=o/oauth2/auth' \
91- -s 'auth/oauth2/user_agent/ClientId=1041829795610-htf69c529db58qcq8jvf58bijn1ie3oi.apps.googleusercontent.com' \
92- -s 'auth/oauth2/user_agent/RedirectUri=http://www.mardy.it/oauth2callback' \
93- -s 'as:auth/oauth2/user_agent/ResponseType=["token"]')
94-
95-ID="$(./account-console create google ${CREATION_PARAMS[@]})"
96-./account-console edit "$ID" --username "$USERNAME"
97-

Subscribers

People subscribed via source and target branches