Merge lp:~mardy/account-plugins/quote-owncloud-1626454 into lp:account-plugins

Proposed by Alberto Mardegan on 2016-09-23
Status: Merged
Approved by: Alberto Mardegan on 2016-09-23
Approved revision: 171
Merged at revision: 174
Proposed branch: lp:~mardy/account-plugins/quote-owncloud-1626454
Merge into: lp:account-plugins
Diff against target: 11 lines (+1/-1)
1 file modified
qml/owncloud/NewAccount.qml (+1/-1)
To merge this branch: bzr merge lp:~mardy/account-plugins/quote-owncloud-1626454
Reviewer Review Type Date Requested Status
Alexandre Abreu (community) 2016-09-23 Approve on 2016-09-23
Review via email: mp+306580@code.launchpad.net

Commit message

Owncloud: properly encode username and password in POST request

Description of the change

Owncloud: properly encode username and password in POST request

To post a comment you must log in.
Alexandre Abreu (abreu-alexandre) wrote :

LGTM

review: Approve
Santosh (santoshbit2007) wrote :

lgtm

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'qml/owncloud/NewAccount.qml'
--- qml/owncloud/NewAccount.qml 2016-08-02 11:54:53 +0000
+++ qml/owncloud/NewAccount.qml 2016-09-23 06:55:47 +0000
@@ -202,7 +202,7 @@
202 }202 }
203 request.open("POST", host + "/ocs/v1.php/person/check", true);203 request.open("POST", host + "/ocs/v1.php/person/check", true);
204 request.setRequestHeader("Content-type", "application/x-www-form-urlencoded");204 request.setRequestHeader("Content-type", "application/x-www-form-urlencoded");
205 var body = "login=" + username + "&password=" + password205 var body = "login=" + encodeURIComponent(username) + "&password=" + encodeURIComponent(password)
206 request.send(body);206 request.send(body);
207 }207 }
208208

Subscribers

People subscribed via source and target branches

to all changes: