Online Accounts: Account plugins

Merge lp:~mardy/account-plugins/quote-owncloud-1626454 into lp:account-plugins

  1. quote-owncloud-1626454
  2. Merge into trunk
Proposed by Alberto Mardegan
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 171
Merged at revision: 174
Proposed branch: lp:~mardy/account-plugins/quote-owncloud-1626454
Merge into: lp:account-plugins
Diff against target: 11 lines (+1/-1)
1 file modified
qml/owncloud/NewAccount.qml (+1/-1)
To merge this branch: bzr merge lp:~mardy/account-plugins/quote-owncloud-1626454
Reviewer Review Type Date Requested Status
Alexandre Abreu (community) Approve
Review via email: mp+306580@code.launchpad.net

Commit message

Owncloud: properly encode username and password in POST request

Description of the change

Owncloud: properly encode username and password in POST request

To post a comment you must log in.
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

LGTM

review: Approve
Revision history for this message
Santosh (santoshbit2007) wrote :

lgtm

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/owncloud/NewAccount.qml'
2--- qml/owncloud/NewAccount.qml 2016-08-02 11:54:53 +0000
3+++ qml/owncloud/NewAccount.qml 2016-09-23 06:55:47 +0000
4@@ -202,7 +202,7 @@
5 }
6 request.open("POST", host + "/ocs/v1.php/person/check", true);
7 request.setRequestHeader("Content-type", "application/x-www-form-urlencoded");
8- var body = "login=" + username + "&password=" + password
9+ var body = "login=" + encodeURIComponent(username) + "&password=" + encodeURIComponent(password)
10 request.send(body);
11 }
12

Subscribers

People subscribed via source and target branches