Merge lp:~mardy/account-plugins/new-oauth-plugin into lp:account-plugins

Proposed by Alberto Mardegan on 2014-09-10
Status: Merged
Approved by: David Barth on 2014-09-15
Approved revision: 140
Merged at revision: 140
Proposed branch: lp:~mardy/account-plugins/new-oauth-plugin
Merge into: lp:account-plugins
Diff against target: 39 lines (+9/-1)
3 files modified
configure.ac (+1/-1)
data/providers/google.provider.in.in (+1/-0)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp:~mardy/account-plugins/new-oauth-plugin
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve on 2014-09-11
David Barth (community) 2014-09-10 Approve on 2014-09-10
Review via email: mp+234060@code.launchpad.net

Commit message

Google: add ForceClientAuthViaRequestBody flag

The next version of signon-plugin-oauth2 will use HTTP Basic authorization for
authorizing the client, as recommended by the OAuth 2.0 specification. However,
Google does not support it, and therefore we need to add this special flag to
force the oauth2 plugin to authenticate the client by passing ClientId and
ClientSecret in the request body.
We don't need to update the dependency version, because older versions of
signon-plugin-oauth2 will simply ignore this flag.

Description of the change

Google: add ForceClientAuthViaRequestBody flag

The next version of signon-plugin-oauth2 will use HTTP Basic authorization for
authorizing the client, as recommended by the OAuth 2.0 specification. However,
Google does not support it, and therefore we need to add this special flag to
force the oauth2 plugin to authenticate the client by passing ClientId and
ClientSecret in the request body.
We don't need to update the dependency version, because older versions of
signon-plugin-oauth2 will simply ignore this flag.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2013-06-12 05:49:46 +0000
3+++ configure.ac 2014-09-11 10:07:46 +0000
4@@ -1,7 +1,7 @@
5 dnl Process this file with autoconf to produce a configure script.
6
7 AC_INIT([account-plugins],
8- [0.11],
9+ [0.12],
10 [https://bugs.launchpad.net/online-accounts-account-plugins/+filebug],
11 [account-plugins],
12 [https://launchpad.net/online-accounts-account-plugins])
13
14=== modified file 'data/providers/google.provider.in.in'
15--- data/providers/google.provider.in.in 2014-03-07 15:03:19 +0000
16+++ data/providers/google.provider.in.in 2014-09-11 10:07:46 +0000
17@@ -23,6 +23,7 @@
18 <setting name="ClientId">@GOOGLE_CLIENT_ID@</setting>
19 <setting name="ClientSecret">@GOOGLE_CLIENT_SECRET@</setting>
20 <setting name="AllowedSchemes" type="as">['https','http']</setting>
21+ <setting name="ForceClientAuthViaRequestBody" type="b">true</setting>
22 </group>
23 </group>
24 </group>
25
26=== modified file 'debian/changelog'
27--- debian/changelog 2014-04-09 17:58:26 +0000
28+++ debian/changelog 2014-09-11 10:07:46 +0000
29@@ -1,3 +1,10 @@
30+account-plugins (0.12-0ubuntu1) UNRELEASED; urgency=medium
31+
32+ * Google: add ForceClientAuthViaRequestBody flag, required by the new
33+ signon-plugin-oauth2
34+
35+ -- Alberto Mardegan <alberto.mardegan@canonical.com> Thu, 11 Sep 2014 13:04:44 +0300
36+
37 account-plugins (0.11+14.04.20140409.1-0ubuntu1) trusty; urgency=low
38
39 [ Ubuntu daily release ]

Subscribers

People subscribed via source and target branches

to all changes: