Code review comment for lp:~mardy/account-plugins/microsoft-graph

Revision history for this message
Gary.Wang (gary-wzl77) wrote :

I re-tested the account plugin and found that I didn't change the Scope settings, which resulted in login failure.
Also with this plugin, access token is only available by using Microsoft graph API. So I compared all the APIs of onedrive I used in scope and storage provider
   https://dev.onedrive.com
with graph API
   https://graph.microsoft.io/en-us/docs/api-reference/v1.0/api/item_createuploadsession#best-practices)
Basically, these two sets of APIs are quite similar. With some parameters changed, I can easily migrate onedrive API to graph API.
So there's no much efforts for this transition.
Thanks for this. Mardy

review: Approve

« Back to merge proposal