Online Accounts: Account plugins

Merge lp:~mardy/account-plugins/lp1441476 into lp:account-plugins

  1. lp1441476
  2. Merge into trunk
Proposed by Alberto Mardegan
Status: Merged
Approved by: David Barth
Approved revision: 146
Merged at revision: 146
Proposed branch: lp:~mardy/account-plugins/lp1441476
Merge into: lp:account-plugins
Diff against target: 12 lines (+1/-1)
1 file modified
qml/facebook/Main.qml (+1/-1)
To merge this branch: bzr merge lp:~mardy/account-plugins/lp1441476
Reviewer Review Type Date Requested Status
David Barth (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+255777@code.launchpad.net

Commit message

The "username" field has been removed in the 2.0 API

https://developers.facebook.com/docs/apps/upgrading/

Description of the change

The "username" field has been removed in the 2.0 API

https://developers.facebook.com/docs/apps/upgrading/

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:146
http://jenkins.qa.ubuntu.com/job/account-plugins-ci/37/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-plugins-vivid-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-plugins-vivid-armhf-ci/3
        deb: http://jenkins.qa.ubuntu.com/job/account-plugins-vivid-armhf-ci/3/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-plugins-vivid-i386-ci/3

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/account-plugins-ci/37/rebuild

review: Approve (continuous-integration)
Revision history for this message
David Barth (dbarth) :
review: Approve
Revision history for this message
David Barth (dbarth) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/facebook/Main.qml'
2--- qml/facebook/Main.qml 2013-06-07 11:56:25 +0000
3+++ qml/facebook/Main.qml 2015-04-10 05:41:23 +0000
4@@ -13,7 +13,7 @@
5 console.log("ok")
6 console.log("response text: " + http.responseText)
7 var response = JSON.parse(http.responseText)
8- account.updateDisplayName(response.username)
9+ account.updateDisplayName(response.name)
10 globalAccountService.updateSettings({
11 'id': response.id
12 })

Subscribers

People subscribed via source and target branches