Online Accounts: Account plugins

Merge lp:~mardy/account-plugins/lp1429911 into lp:account-plugins

  1. lp1429911
  2. Merge into trunk
Proposed by Alberto Mardegan on 2015-03-09
Status: Merged
Approved by: David Barth on 2015-03-20
Approved revision: 145
Merged at revision: 144
Proposed branch: lp:~mardy/account-plugins/lp1429911
Merge into: lp:account-plugins
Diff against target: 14 lines (+2/-1)
1 file modified
data/providers/facebook.provider.in.in (+2/-1)
To merge this branch: bzr merge lp:~mardy/account-plugins/lp1429911
Reviewer Review Type Date Requested Status
David Barth (community) 2015-03-09 Approve on 2015-03-11
PS Jenkins bot continuous-integration Approve on 2015-03-11
Review via email: mp+252326@code.launchpad.net

Commit Message

Add required ResponseType parameter to Facebook plugin.

Description of the Change

Add required ResponseType parameter to Facebook plugin.

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
lp:~mardy/account-plugins/lp1429911 updated on 2015-03-11
145. By Alberto Mardegan on 2015-03-11

Don't use v1.0 permissions

PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
David Barth (dbarth) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/providers/facebook.provider.in.in'
2--- data/providers/facebook.provider.in.in 2014-09-24 08:27:39 +0000
3+++ data/providers/facebook.provider.in.in 2015-03-11 09:29:43 +0000
4@@ -16,8 +16,9 @@
5 <setting name="Host">www.facebook.com</setting>
6 <setting name="AuthPath">/dialog/oauth</setting>
7 <setting name="RedirectUri">https://www.facebook.com/connect/login_success.html</setting>
8+ <setting name="ResponseType">token</setting>
9 <setting name="Display">popup</setting>
10- <setting name="Scope" type="as">['publish_stream','read_stream','status_update','user_photos','friends_photos','xmpp_login']</setting>
11+ <setting name="Scope" type="as">['publish_actions','read_stream','user_photos']</setting>
12 <setting name="ClientId">@FACEBOOK_CLIENT_ID@</setting>
13 <setting name="AllowedSchemes" type="as">['https','http']</setting>
14 </group>

Subscribers

People subscribed via source and target branches

to all changes: