Merge lp:~mardy/account-plugins/lp1180297 into lp:account-plugins/13.04

Proposed by Alberto Mardegan on 2013-05-27
Status: Merged
Approved by: Ken VanDine on 2013-06-04
Approved revision: 97
Merged at revision: 97
Proposed branch: lp:~mardy/account-plugins/lp1180297
Merge into: lp:account-plugins/13.04
Diff against target: 11 lines (+1/-0)
1 file modified
data/providers/facebook.provider.in.in (+1/-0)
To merge this branch: bzr merge lp:~mardy/account-plugins/lp1180297
Reviewer Review Type Date Requested Status
Ken VanDine 2013-05-27 Approve on 2013-06-04
PS Jenkins bot (community) continuous-integration Approve on 2013-05-28
Online Accounts 2013-05-27 Pending
Review via email: mp+165814@code.launchpad.net

Commit message

Allow Facebook to connect via plain HTTP

Workaround for https://developers.facebook.com/bugs/449221825171392

Description of the change

Allow Facebook to connect via plain HTTP

Workaround for https://developers.facebook.com/bugs/449221825171392

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Ken VanDine (ken-vandine) wrote :

Looks good, not ideal, but we need to work around the problem with facebook. We did get approval from the security team on bug 1180297

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/providers/facebook.provider.in.in'
2--- data/providers/facebook.provider.in.in 2013-02-25 06:25:34 +0000
3+++ data/providers/facebook.provider.in.in 2013-05-27 06:21:28 +0000
4@@ -18,6 +18,7 @@
5 <setting name="Display">popup</setting>
6 <setting name="Scope" type="as">['publish_stream','read_stream','status_update','user_photos','friends_photos','xmpp_login']</setting>
7 <setting name="ClientId">@FACEBOOK_CLIENT_ID@</setting>
8+ <setting name="AllowedSchemes" type="as">['https','http']</setting>
9 </group>
10 </group>
11 </group>

Subscribers

People subscribed via source and target branches