Merge lp:~mardy/account-plugins/facebook-http into lp:account-plugins/12.10

Proposed by Alberto Mardegan on 2013-02-25
Status: Merged
Approved by: David King on 2013-02-25
Approved revision: 76
Merge reported by: Alberto Mardegan
Merged at revision: not available
Proposed branch: lp:~mardy/account-plugins/facebook-http
Merge into: lp:account-plugins/12.10
Diff against target: 20 lines (+10/-0)
1 file modified
src/facebook.vala (+10/-0)
To merge this branch: bzr merge lp:~mardy/account-plugins/facebook-http
Reviewer Review Type Date Requested Status
David King (community) 2013-02-25 Approve on 2013-02-25
Review via email: mp+150272@code.launchpad.net

Commit message

Allow Facebook authentication to happen via plain HTTP

For some reason, now Facebook redirects to a plain HTTP page:
http://developers.facebook.com/bugs/427626840651838

Description of the change

Allow Facebook authentication to happen via plain HTTP

For some reason, now Facebook redirects to a plain HTTP page:
http://developers.facebook.com/bugs/427626840651838

To post a comment you must log in.
David King (amigadave) wrote :

Sigh, I guess we have to do this. :-(

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/facebook.vala'
2--- src/facebook.vala 2012-11-12 11:24:22 +0000
3+++ src/facebook.vala 2013-02-25 07:27:22 +0000
4@@ -42,6 +42,16 @@
5 "xmpp_login"
6 };
7 oauth_params.insert ("Scope", scopes);
8+
9+ /* We must allow http as well:
10+ * http://developers.facebook.com/bugs/427626840651838
11+ */
12+ string[] schemes = {
13+ "https",
14+ "http"
15+ };
16+ oauth_params.insert ("AllowedSchemes", schemes);
17+
18 set_oauth_parameters (oauth_params);
19 }
20 }

Subscribers

People subscribed via source and target branches