Code review comment for lp:~marcustomlinson/unity-scopes-shell/lp-1552082

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Thanks, good stuff! Just one more observation (see the inline comment).
Also, can you make sure settingsChanged() signal is only emited when actual change was succesful (in the old code we had only one case where stuff could go wrong in settings_timout() and it wouldn't emit settingsChanged; now we have new exceptions to deal with but they only result in a qWarning and signal is emited) ?

review: Needs Fixing

« Back to merge proposal