Code review comment for lp:~marcustomlinson/unity-scopes-shell/lp-1552082
Revision history for this message
| Michi Henning (michihenning) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
> Before, QSettings would never throw obviously. With the proposed changes to
> IniParser, an exception from the ctor means it failed on open *or* on
> obtaining the read lock. Now, when the latter happens, we will try to
> overwrite the file which may or may not succeed (and potentially overwrite
> user changes doing so) but we will also try to create IniParser instance,
> which may throw again and this is not handled (makes shell crash).
Currently, the ini parser doesn't try to get a lock. Instead, this happens inside SettingsDB in scopes API. I think we need to use the same locking that is done by SettingsDB.cpp in scopes API. The ini parser itself shouldn't do any locking.