Merge lp:~marcustomlinson/unity-scopes-api/locate_test_order_fix into lp:unity-scopes-api/devel

Proposed by Marcus Tomlinson
Status: Merged
Approved by: Michal Hruby
Approved revision: 289
Merged at revision: 288
Proposed branch: lp:~marcustomlinson/unity-scopes-api/locate_test_order_fix
Merge into: lp:unity-scopes-api/devel
Diff against target: 15 lines (+4/-1)
1 file modified
test/gtest/scopes/internal/zmq_middleware/RegistryI/RegistryI_test.cpp (+4/-1)
To merge this branch: bzr merge lp:~marcustomlinson/unity-scopes-api/locate_test_order_fix
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Michal Hruby (community) Approve
Review via email: mp+213521@code.launchpad.net

Commit message

Start scope-C and scope-D before starting scope-B in RegistryI_test, as B aggregates C and D. (When re-binding logic is introduced, this will be unnecessary)

To post a comment you must log in.
289. By Marcus Tomlinson

Added comment to test to be addressed when re-binding in added

Revision history for this message
Michal Hruby (mhr3) wrote :

+1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'test/gtest/scopes/internal/zmq_middleware/RegistryI/RegistryI_test.cpp'
2--- test/gtest/scopes/internal/zmq_middleware/RegistryI/RegistryI_test.cpp 2014-03-24 10:19:35 +0000
3+++ test/gtest/scopes/internal/zmq_middleware/RegistryI/RegistryI_test.cpp 2014-03-31 17:27:14 +0000
4@@ -423,7 +423,10 @@
5 mw->add_registry_object(reg_id, reg);
6
7 // configure scopes
8- std::array<std::string, 6> scope_ids = {"scope-A", "scope-B", "scope-C", "scope-D", "scope-N", "scope-S"};
9+ ///! TODO: HACK:
10+ /// we have to start scope-C and scope-D before starting scope-B here, as B aggregates C and D.
11+ /// (When re-binding logic is introduced, this will be unnecessary)
12+ std::array<std::string, 6> scope_ids = {"scope-A", "scope-C", "scope-D", "scope-B", "scope-N", "scope-S"};
13 std::map<std::string, ScopeProxy> proxies;
14
15 for (auto& scope_id : scope_ids)

Subscribers

People subscribed via source and target branches

to all changes: