unity-scopes-api

Merge lp:~marcustomlinson/unity-scopes-api/fix_acl into lp:unity-scopes-api

  1. fix_acl
  2. Merge into trunk
Proposed by Marcus Tomlinson
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 288
Merged at revision: 288
Proposed branch: lp:~marcustomlinson/unity-scopes-api/fix_acl
Merge into: lp:unity-scopes-api
Diff against target: 53 lines (+6/-0)
2 files modified
src/scopes/internal/OnlineAccountClientImpl.cpp (+2/-0)
test/gtest/scopes/OnlineAccountClient/OnlineAccountClient_test.cpp (+4/-0)
To merge this branch: bzr merge lp:~marcustomlinson/unity-scopes-api/fix_acl
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+247551@code.launchpad.net

Commit message

Embed scope ID into the OA details of a log-in item

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:288
http://jenkins.qa.ubuntu.com/job/unity-scopes-api-ci/553/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-amd64-ci/80
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-armhf-ci/78
        deb: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-armhf-ci/78/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-i386-ci/79

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scopes-api-ci/553/rebuild

review: Approve (continuous-integration)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/scopes/internal/OnlineAccountClientImpl.cpp'
2--- src/scopes/internal/OnlineAccountClientImpl.cpp 2014-12-10 10:06:25 +0000
3+++ src/scopes/internal/OnlineAccountClientImpl.cpp 2015-01-26 06:03:55 +0000
4@@ -454,6 +454,7 @@
5 }
6
7 VariantMap account_details_map;
8+ account_details_map["scope_id"] = query.scope_id();
9 account_details_map["service_name"] = service_name_;
10 account_details_map["service_type"] = service_type_;
11 account_details_map["provider_name"] = provider_name_;
12@@ -468,6 +469,7 @@
13 OnlineAccountClient::PostLoginAction login_failed_action)
14 {
15 VariantMap account_details_map;
16+ account_details_map["scope_id"] = "";
17 account_details_map["service_name"] = service_name_;
18 account_details_map["service_type"] = service_type_;
19 account_details_map["provider_name"] = provider_name_;
20
21=== modified file 'test/gtest/scopes/OnlineAccountClient/OnlineAccountClient_test.cpp'
22--- test/gtest/scopes/OnlineAccountClient/OnlineAccountClient_test.cpp 2014-12-03 10:47:40 +0000
23+++ test/gtest/scopes/OnlineAccountClient/OnlineAccountClient_test.cpp 2015-01-26 06:03:55 +0000
24@@ -313,12 +313,14 @@
25
26 VariantMap details = result.value("online_account_details").get_dict();
27
28+ EXPECT_NE(details.end(), details.find("scope_id"));
29 EXPECT_NE(details.end(), details.find("service_name"));
30 EXPECT_NE(details.end(), details.find("service_type"));
31 EXPECT_NE(details.end(), details.find("provider_name"));
32 EXPECT_NE(details.end(), details.find("login_passed_action"));
33 EXPECT_NE(details.end(), details.find("login_failed_action"));
34
35+ EXPECT_EQ("test", details.at("scope_id").get_string());
36 EXPECT_EQ("test_service_name", details.at("service_name").get_string());
37 EXPECT_EQ("test_service_type", details.at("service_type").get_string());
38 EXPECT_EQ("test_provider", details.at("provider_name").get_string());
39@@ -340,12 +342,14 @@
40
41 VariantMap details = values.at("online_account_details").get_dict();
42
43+ EXPECT_NE(details.end(), details.find("scope_id"));
44 EXPECT_NE(details.end(), details.find("service_name"));
45 EXPECT_NE(details.end(), details.find("service_type"));
46 EXPECT_NE(details.end(), details.find("provider_name"));
47 EXPECT_NE(details.end(), details.find("login_passed_action"));
48 EXPECT_NE(details.end(), details.find("login_failed_action"));
49
50+ EXPECT_EQ("", details.at("scope_id").get_string());
51 EXPECT_EQ("test_service_name", details.at("service_name").get_string());
52 EXPECT_EQ("test_service_type", details.at("service_type").get_string());
53 EXPECT_EQ("test_provider", details.at("provider_name").get_string());

Subscribers

People subscribed via source and target branches

to all changes: