Merge lp:~marcustomlinson/unity-js-scopes/iojs-to-nodejs into lp:unity-js-scopes

Proposed by Marcus Tomlinson
Status: Merged
Approved by: Alexandre Abreu
Approved revision: 114
Merged at revision: 114
Proposed branch: lp:~marcustomlinson/unity-js-scopes/iojs-to-nodejs
Merge into: lp:unity-js-scopes
Prerequisite: lp:~marcustomlinson/unity-js-scopes/add-harness-tests
Diff against target: 186 lines (+24/-24)
10 files modified
.bzrignore (+1/-1)
CMakeLists.txt (+5/-5)
README.md (+1/-1)
deps/build-debug.sh (+2/-2)
deps/build.sh (+2/-2)
deps/get.sh (+4/-4)
src/bindings/CMakeLists.txt (+1/-1)
src/common/CMakeLists.txt (+6/-6)
src/launcher/CMakeLists.txt (+1/-1)
src/tool/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~marcustomlinson/unity-js-scopes/iojs-to-nodejs
Reviewer Review Type Date Requested Status
Alexandre Abreu (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+277421@code.launchpad.net

Commit message

Update our io.js dependancy to latest stable node.js (v4)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alexandre Abreu (abreu-alexandre) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.bzrignore'
2--- .bzrignore 2015-10-22 05:41:05 +0000
3+++ .bzrignore 2015-11-13 08:51:28 +0000
4@@ -1,4 +1,4 @@
5-./deps/io.js
6+./deps/node.js
7 ./deps/v8-cpp
8 ./CMakeLists.txt.user
9 ./examples/simple-click/CMakeLists.txt.user
10
11=== modified file 'CMakeLists.txt'
12--- CMakeLists.txt 2015-11-13 08:51:28 +0000
13+++ CMakeLists.txt 2015-11-13 08:51:28 +0000
14@@ -41,9 +41,9 @@
15 endif()
16
17 include_directories(
18- ${CMAKE_CURRENT_SOURCE_DIR}/deps/io.js/deps/uv/include
19- ${CMAKE_CURRENT_SOURCE_DIR}/deps/io.js/deps/v8/include
20- ${CMAKE_CURRENT_SOURCE_DIR}/deps/io.js/src
21+ ${CMAKE_CURRENT_SOURCE_DIR}/deps/node.js/deps/uv/include
22+ ${CMAKE_CURRENT_SOURCE_DIR}/deps/node.js/deps/v8/include
23+ ${CMAKE_CURRENT_SOURCE_DIR}/deps/node.js/src
24 ${CMAKE_CURRENT_SOURCE_DIR}/deps/v8-cpp/src
25 ${CMAKE_CURRENT_SOURCE_DIR}/src
26 )
27@@ -51,11 +51,11 @@
28 string(TOLOWER "${CMAKE_BUILD_TYPE}" cmake_build_type_tolower)
29 if(cmake_build_type_tolower STREQUAL "debug")
30 link_directories(
31- ${CMAKE_CURRENT_SOURCE_DIR}/deps/io.js/out/Debug
32+ ${CMAKE_CURRENT_SOURCE_DIR}/deps/node.js/out/Debug
33 )
34 else()
35 link_directories(
36- ${CMAKE_CURRENT_SOURCE_DIR}/deps/io.js/out/Release
37+ ${CMAKE_CURRENT_SOURCE_DIR}/deps/node.js/out/Release
38 )
39 endif()
40
41
42=== modified file 'README.md'
43--- README.md 2015-10-06 18:22:09 +0000
44+++ README.md 2015-11-13 08:51:28 +0000
45@@ -1,4 +1,4 @@
46-IoJs addon for Ubuntu unity-scopes-api bindings
47+Node.js addon for Ubuntu unity-scopes-api bindings
48 -----------------------------------------------
49
50
51
52=== modified file 'deps/build-debug.sh'
53--- deps/build-debug.sh 2015-08-04 13:58:19 +0000
54+++ deps/build-debug.sh 2015-11-13 08:51:28 +0000
55@@ -2,10 +2,10 @@
56
57 DIR=$(readlink -f $(dirname ${BASH_SOURCE[0]}))
58
59-# io.js
60+# node.js
61
62 cd $DIR
63
64-cd io.js
65+cd node.js
66 ./configure --enable-static --debug
67 make -j3
68
69=== modified file 'deps/build.sh'
70--- deps/build.sh 2015-08-04 13:58:19 +0000
71+++ deps/build.sh 2015-11-13 08:51:28 +0000
72@@ -2,10 +2,10 @@
73
74 DIR=$(readlink -f $(dirname ${BASH_SOURCE[0]}))
75
76-# io.js
77+# node.js
78
79 cd $DIR
80
81-cd io.js
82+cd node.js
83 ./configure --enable-static
84 make -j3
85
86=== modified file 'deps/get.sh'
87--- deps/get.sh 2015-08-04 09:06:45 +0000
88+++ deps/get.sh 2015-11-13 08:51:28 +0000
89@@ -3,12 +3,12 @@
90 DIR=$(readlink -f $(dirname ${BASH_SOURCE[0]}))
91 cd $DIR
92
93-# io.js
94+# node.js
95
96-if [ -d "io.js" ]; then
97- cd io.js; cd ..
98+if [ -d "node.js" ]; then
99+ cd node.js; cd ..
100 else
101- bzr branch http://bazaar.launchpad.net/~webapps/unity-js-scopes/io.js io.js
102+ bzr branch http://bazaar.launchpad.net/~webapps/unity-js-scopes/node.js node.js
103 fi
104
105 # v8cpp
106
107=== modified file 'src/bindings/CMakeLists.txt'
108--- src/bindings/CMakeLists.txt 2015-11-13 08:51:28 +0000
109+++ src/bindings/CMakeLists.txt 2015-11-13 08:51:28 +0000
110@@ -103,7 +103,7 @@
111 "${CMAKE_BINARY_DIR}/tests/node_modules/unity-js-scopes/lib"
112 )
113
114-install(DIRECTORY ${CMAKE_SOURCE_DIR}/deps/io.js/deps/npm
115+install(DIRECTORY ${CMAKE_SOURCE_DIR}/deps/node.js/deps/npm
116 DESTINATION /node_modules
117 USE_SOURCE_PERMISSIONS
118 )
119
120=== modified file 'src/common/CMakeLists.txt'
121--- src/common/CMakeLists.txt 2015-09-30 06:10:51 +0000
122+++ src/common/CMakeLists.txt 2015-11-13 08:51:28 +0000
123@@ -17,19 +17,19 @@
124 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
125
126 add_library(
127- iojs-static
128+ nodejs-static
129 config.h
130 )
131
132 set_target_properties(
133- iojs-static PROPERTIES
134+ nodejs-static PROPERTIES
135 LINKER_LANGUAGE CXX
136 )
137
138 target_link_libraries(
139- iojs-static
140+ nodejs-static
141
142- -Wl,--whole-archive iojs -Wl,--no-whole-archive
143+ -Wl,--whole-archive node -Wl,--no-whole-archive
144 uv
145 cares
146 openssl
147@@ -47,12 +47,12 @@
148
149 if(cmake_build_type_tolower STREQUAL "debug")
150 add_custom_command(
151- TARGET iojs-static PRE_LINK
152+ TARGET nodejs-static PRE_LINK
153 COMMAND ${CMAKE_SOURCE_DIR}/deps/build-debug.sh
154 )
155 else()
156 add_custom_command(
157- TARGET iojs-static PRE_LINK
158+ TARGET nodejs-static PRE_LINK
159 COMMAND ${CMAKE_SOURCE_DIR}/deps/build.sh
160 )
161 endif()
162
163=== modified file 'src/launcher/CMakeLists.txt'
164--- src/launcher/CMakeLists.txt 2015-11-13 08:51:28 +0000
165+++ src/launcher/CMakeLists.txt 2015-11-13 08:51:28 +0000
166@@ -64,7 +64,7 @@
167
168 target_link_libraries(
169 ${LAUNCHER_EXECUTABLE_NAME}
170- iojs-static
171+ nodejs-static
172 ${Boost_LIBRARIES}
173 )
174
175
176=== modified file 'src/tool/CMakeLists.txt'
177--- src/tool/CMakeLists.txt 2015-09-30 06:10:51 +0000
178+++ src/tool/CMakeLists.txt 2015-11-13 08:51:28 +0000
179@@ -64,7 +64,7 @@
180
181 target_link_libraries(
182 ${TOOL_EXECUTABLE_NAME}
183- iojs-static
184+ nodejs-static
185 ${Boost_LIBRARIES}
186 )
187

Subscribers

People subscribed via source and target branches

to all changes: