Code review comment for lp:~marcustomlinson/unity-js-scopes/build-fixes

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Hey Alex, I had trouble getting things building and running on my machine. I had to make these changes to get it going.

First issue I had was unity-js-scopes-launcher not recognising the scope.ini argument from the ScopeRunner entry in the example. Then I got "Error: No such module: contextify" when node::Start() was hit.

These changes fixed the above issues I was having, but now I'm still having an issue getting the scope running via unity-scope-tool. I'm calling "unity-scope-tool './examples/simple/simple.ini'", but the scope seems to just hang on startup. Running "unity-js-scopes-launcher './examples/simple/simple.ini'", just gives me the node terminal (">"). I looks like the simple.js script is either not even running, or is failing and no error message is being shown.

Sorry for rambling, I hope I'm making sense here.

I'm not proposing that these changes are all sane :p Please have a look through them and let me know if I'm doing anything stupid / if you have any better solutions.

« Back to merge proposal