Unity API

Code review comment for lp:~marcustomlinson/unity-api/lp-1552082

  1. lp-1552082
  2. Merge into trunk
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Looks good! Only problem is missing file locking, mention in the review of https://code.launchpad.net/~marcustomlinson/unity-scopes-shell/lp-1552082/+merge/288918

Also, can you mention in the headers docs that sync() may throw? Can you add a test case for exception on sync()?

review: Needs Fixing

« Back to merge proposal