Merge lp:~marcustomlinson/libdbusmenu-qt/recursive-menu-refresh into lp:libdbusmenu-qt
Proposed by
Marcus Tomlinson
Status: | Merged |
---|---|
Approved by: | Ted Gould |
Approved revision: | 252 |
Merged at revision: | 253 |
Proposed branch: | lp:~marcustomlinson/libdbusmenu-qt/recursive-menu-refresh |
Merge into: | lp:libdbusmenu-qt |
Diff against target: |
23 lines (+6/-0) 1 file modified
src/dbusmenuimporter.cpp (+6/-0) |
To merge this branch: | bzr merge lp:~marcustomlinson/libdbusmenu-qt/recursive-menu-refresh |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ted Gould (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+196268@code.launchpad.net |
Commit message
When adding a new submenu action, refresh() that action to ensure full menu hierarchy is built.
To post a comment you must log in.
We were experiencing a problem in HUD when updating the dbusmenu QMenu. We would have to continuously loop through the entire menu hierarchy repeatedly calling aboutToShow() on each menu and submenu until no more menus appeared. This fix now causes the contained menu hierarchy to be updated recursively allowing us to make only one pass through the QMenu structure getting all actions.