Juju Charms Collection
ntp package

Merge lp:~marcoceppi/charms/trusty/ntp/status into lp:charms/trusty/ntp

  1. Trusty Tahr (14.04)
  2. status
  3. Merge into trunk
Proposed by Marco Ceppi
Status: Merged
Merge reported by: Stuart Bishop
Merged at revision: not available
Proposed branch: lp:~marcoceppi/charms/trusty/ntp/status
Merge into: lp:charms/trusty/ntp
Diff against target: 12 lines (+2/-0)
1 file modified
hooks/ntp_hooks.py (+2/-0)
To merge this branch: bzr merge lp:~marcoceppi/charms/trusty/ntp/status
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Needs Fixing
Review via email: mp+306860@code.launchpad.net

Description of the change

Adds status-set support

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :

in-sync is technically a lie. 'Ready', 'Active' or 'Live' is better. Cause just because ntp is running doesn't mean time is synced (network connectivity issues, too much clock skew)

review: Needs Fixing
Revision history for this message
Stuart Bishop (stub) wrote :

Committed to launchpad.net/ntp-charm with adjusted status message

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/ntp_hooks.py'
2--- hooks/ntp_hooks.py 2016-07-19 20:21:01 +0000
3+++ hooks/ntp_hooks.py 2016-09-27 12:03:13 +0000
4@@ -91,6 +91,8 @@
5 if hookenv.relation_ids('nrpe-external-master'):
6 update_nrpe_config()
7
8+ hookenv.status_set('active', 'in-sync')
9+
10
11 @hooks.hook('nrpe-external-master-relation-joined',
12 'nrpe-external-master-relation-changed')

Subscribers

People subscribed via source and target branches

to all changes: