Merge lp:~marcoceppi/charms/trusty/mysql/lp1373862 into lp:charms/trusty/mysql

[Marco Ceppi]

[uosci-testing-bot (uosci-testing-bot)]

charm_lint_check #7988 mysql for marcoceppi mp267948
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/7988/

[uosci-testing-bot (uosci-testing-bot)]

charm_unit_test #7403 mysql for marcoceppi mp267948
    UNIT FAIL: unit-test failed

UNIT Results (max last 2 lines):
make: *** [test] Error 1
ERROR:root:Make target returned non-zero.

Full unit test output: http://paste.ubuntu.com/12071051/
Build: http://10.245.162.77:8080/job/charm_unit_test/7403/

[Ryan Beisner (1chb1n)]

Please see comment on bug 1373862.

If we do move forward with this default value change, we will need to update the amulet test as well.

The test knows about the former 80% default charm config value, in the interest of making sure the "deployed" == the "expected."

As an aside, the unit tests are known-failing (bug 1398918), as they're not really mocking.

review: Disapprove

[Ryan Beisner (1chb1n)]

Marco - can you rebase your proposed branch to ensure that the other landed changes are pulled into this for testing?

[Ryan Beisner (1chb1n)]

Marco - can you rebase your proposed branch to ensure that the other landed changes are pulled into this for testing?

review: Needs Information

Unmerged revisions

147. By Marco Ceppi on 2015-08-13

Sane dataset-size. Fixes local provider and is recommended value from MySQL experts

=== modified file 'config.yaml'
--- config.yaml	2015-04-21 06:59:10 +0000
+++ config.yaml	2015-08-13 13:27:49 +0000
@@ -1,6 +1,6 @@
 options:
     dataset-size:
-        default: '80%'
+        default: '128M'
         description: How much data do you want to keep in memory in the DB. This will be used to tune settings in the database server appropriately. Any more specific settings will override these defaults though. This currently sets innodb_buffer_pool_size or key_cache_size depending on the setting in preferred-storage-engine. If query-cache-type is set to 'ON' or 'DEMAND' 20% of this is given to query-cache-size. Suffix this value with 'K','M','G', or 'T' to get the relevant kilo/mega/etc. bytes. If suffixed with %, one will get that percentage of RAM devoted to dataset and (if enabled) query cache.
         type: string
     preferred-storage-engine: