Merge lp:~marcoceppi/charms/precise/thinkup/tests into lp:~charmers/charms/precise/thinkup/trunk

[Marco Ceppi]

Tests for charm

[Cory Johns (johnsca)]

`charm proof` failed due to missing README, missing "tags" field from metadata, and missing "default" in config options.

I also got an SSL error during the install hook which caused the 99-autogen test to fail, but it seems likely that this is temporary and caused by a third-party issue.

review: Needs Fixing

[Cory Johns (johnsca)]

Fixed charm proof issues in https://code.launchpad.net/~johnsca/charms/precise/thinkup/charm-proof/+merge/243469 with a super-boilerplate README

[Review Queue (review-queue)]

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-10644-results

review: Needs Fixing (automated testing)

[lp:~marcoceppi/charms/precise/thinkup/tests]

23. By Marco Ceppi on 2014-12-18

[johnsca] Boilerplate README and fixed charm proof warnings

[Antonio Rosales (arosales)]

As this merge proposal only add charm tests and does not touch charm code I would like to suggest to accept this merge proposal even though the charm is failing the tests for the following reasons:

1. A test is still valid even if the results aren't positive.
2. Having charm tests provides the first step to helping the charm author and community fix the charm. Specifically by providing a reproducible failure.
3. The tests are seed (basic) tests that an interested person can build off of.
4. As fixes are made to this charm automating charm testing will be able to run additional tests in addition to charm proof.
5. Having basic tests, as demonstrated here, helps ensure the charm is in a working (deployable) state given this charm is a recommended charm. A test failure can prompt a bug the charm author can take action on. The charm author may not have been aware of the bug had the charm not had even basic deployment tests.

In this case the test does deploy a valid thinkup environment, however the install hook fails. A good point to note here is the seed tests help identify this error. We would have not known of the failure with out the tests. Thus, although the charm is failing charm testing, the test itself is valid.

Thus, for the above reason I would suggest to accept this merge to add in tests.

+1 LGTM

review: Approve (community)

[Antonio Rosales (arosales)]

There is a current bug open for the install hook failure:
https://bugs.launchpad.net/charms/+source/thinkup/+bug/1367491

[José Antonio Rey (jose)]

I am not able to merge this until the conflicts are resolved.

review: Needs Fixing (charmers)

[Charles Butler (lazypower)]

Resolved the README.md conflict and pushed this.

Thanks for your work everyone.

review: Approve

=== added file 'README.md'
--- README.md	1970-01-01 00:00:00 +0000
+++ README.md	2014-12-18 01:41:31 +0000
@@ -0,0 +1,26 @@
+# Overview
+
+ThinkUp is a free, installable web application that gives you insights into your
+activity on social networks, including Twitter, Facebook, Foursquare, and
+Google+. Find out more at http://thinkup.com.
+
+# Usage
+
+You can deploy the charm using the following:
+
+    juju deploy servicename
+    juju deploy haproxy
+    juju deploy mysql
+    juju add-relation thinkup:website haproxy:reverseproxy
+    juju add-relation thinkup:db mysql:db
+    juju expose haproxy
+
+Then browse to the public-address for the haproxy service which can be retrieved
+via:
+
+    juju status haproxy
+
+## Upstream Project Name
+
+- https://www.thinkup.com/
+- https://github.com/ginatrapani/ThinkUp

=== renamed file 'README.md' => 'README.md.moved'
=== modified file 'config.yaml'
--- config.yaml	2014-10-23 14:55:39 +0000
+++ config.yaml	2014-12-18 01:41:31 +0000
@@ -7,14 +7,17 @@
     default: ""
     type: string
     description: The full name of the administrator
+    default: ''
   email:
     default: ""
     type: string
     description: The email address of the administrator (used for login and cannot be changed after initial value has been set)
+    default: ''
   password:
     default: ""
     type: string
     description: The password of the administrator
+    default: ''
   timezone:
     default: UTC
     type: string

=== modified file 'metadata.yaml'
--- metadata.yaml	2014-10-23 14:55:39 +0000
+++ metadata.yaml	2014-12-18 01:41:31 +0000
@@ -1,6 +1,7 @@
 name: thinkup
 summary: social network aggregator
 maintainer: Nathan Osman <[e-mail]>
+tags: ["applications"]
 description: |
   ThinkUp is a free, open source web application that captures all your
   activity on social networks.

=== added directory 'tests'
=== added file 'tests/00-setup'
--- tests/00-setup	1970-01-01 00:00:00 +0000
+++ tests/00-setup	2014-12-18 01:41:31 +0000
@@ -0,0 +1,5 @@
+#!/bin/bash
+
+sudo add-apt-repository ppa:juju/stable -y
+sudo apt-get update
+sudo apt-get install amulet python3-requests -y

=== added file 'tests/99-autogen'
--- tests/99-autogen	1970-01-01 00:00:00 +0000
+++ tests/99-autogen	2014-12-18 01:41:31 +0000
@@ -0,0 +1,53 @@
+#!/usr/bin/env python3
+
+import amulet
+import requests
+import unittest
+
+
+class TestDeployment(unittest.TestCase):
+    @classmethod
+    def setUpClass(cls):
+        cls.deployment = amulet.Deployment(series='precise')
+
+        cls.deployment.add('thinkup')
+        cls.deployment.add('haproxy')
+        cls.deployment.add('mysql')
+        cls.deployment.relate('thinkup:website', 'haproxy:reverseproxy')
+        cls.deployment.relate('thinkup:db', 'mysql:db')
+
+        try:
+            cls.deployment.setup(timeout=900)
+            cls.deployment.sentry.wait()
+        except amulet.helpers.TimeoutError:
+            amulet.raise_status(amulet.SKIP, msg="Environment wasn't stood up in time")
+        except:
+            raise
+
+    def test_case(self):
+        # Now you can use self.deployment.sentry.unit[UNIT] to address each of
+        # the units and perform more in-depth steps.  You can also reference
+        # the first unit as self.unit.
+        # There are three test statuses that can be triggered with
+        # amulet.raise_status():
+        #   - amulet.PASS
+        #   - amulet.FAIL
+        #   - amulet.SKIP
+        # Each unit has the following methods:
+        #   - .info - An array of the information of that unit from Juju
+        #   - .file(PATH) - Get the details of a file on that unit
+        #   - .file_contents(PATH) - Get plain text output of PATH file from that unit
+        #   - .directory(PATH) - Get details of directory
+        #   - .directory_contents(PATH) - List files and folders in PATH on that unit
+        #   - .relation(relation, service:rel) - Get relation data from return service
+        #          add tests here to confirm service is up and working properly
+        # For example, to confirm that it has a functioning HTTP server:
+        #     page = requests.get('http://{}'.format(self.unit.info['public-address']))
+        #     page.raise_for_status()
+        # More information on writing Amulet tests can be found at:
+        #     https://juju.ubuntu.com/docs/tools-amulet.html
+        pass
+
+
+if __name__ == '__main__':
+    unittest.main()