Merge lp:~marcoceppi/charms/precise/postgresql/ip-hostname-verification into lp:charms/postgresql
Proposed by
Marco Ceppi
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Kapil Thangavelu | ||||
Approved revision: | 32 | ||||
Merged at revision: | 32 | ||||
Proposed branch: | lp:~marcoceppi/charms/precise/postgresql/ip-hostname-verification | ||||
Merge into: | lp:charms/postgresql | ||||
Diff against target: | 0 lines | ||||
To merge this branch: | bzr merge lp:~marcoceppi/charms/precise/postgresql/ip-hostname-verification | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Kapil Thangavelu (community) | Approve | ||
Review via email: mp+148063@code.launchpad.net |
Description of the change
This completes the changes made in rev:30, since ip addresses require a full CIDR, and not all cloud environments provide hostnames, this fix will make sure that hostnames are passed to the template untouched which IP addresses get a /32 appended to the private-addresses. I could not verify this on my local, but the following code executes as expected in the interpreter http://
To post a comment you must log in.
instead of the join, or str('/') [ie. string a string], i'd suggest interpolation
ie. = "%s/32" % relation[ 'private_ address' ]