Merge lp:~marcoceppi/charmrunner/graph-build-fix into lp:charmrunner

Proposed by Marco Ceppi
Status: Merged
Approved by: Kapil Thangavelu
Approved revision: 38
Merged at revision: 37
Proposed branch: lp:~marcoceppi/charmrunner/graph-build-fix
Merge into: lp:charmrunner
Diff against target: 42 lines (+4/-3)
2 files modified
charmrunner/graph.py (+2/-2)
charmrunner/server.py (+2/-1)
To merge this branch: bzr merge lp:~marcoceppi/charmrunner/graph-build-fix
Reviewer Review Type Date Requested Status
Juju-Jitsu Hackers Pending
Review via email: mp+161229@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

looks good to me.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'charmrunner/graph.py'
2--- charmrunner/graph.py 2012-02-15 01:07:42 +0000
3+++ charmrunner/graph.py 2013-04-26 20:44:22 +0000
4@@ -138,8 +138,6 @@
5 if (charm_id, interface) in graph.out_edges(charm_id):
6 continue
7
8- providers[interface] = []
9-
10 for provider, providing in graph.in_edges(interface):
11 if provider in BLACK_LIST:
12 continue
13@@ -148,6 +146,8 @@
14 graph, provider,
15 requested=providing,
16 source=charm_id)):
17+ if interface not in providers:
18+ providers[interface] = []
19 providers[interface].append(chain)
20 break # pick the first solution
21
22
23=== modified file 'charmrunner/server.py'
24--- charmrunner/server.py 2013-03-08 16:27:15 +0000
25+++ charmrunner/server.py 2013-04-26 20:44:22 +0000
26@@ -63,7 +63,7 @@
27 Rule('/plan/<series>/<name>',
28 defaults={'revno': None, 'owner': 'charmers'},
29 endpoint='plan'),
30- Rule('/plan/<series>/<name>-<revno>',
31+ Rule('/plan/<series>/<name>:<revno>',
32 defaults={'owner': 'charmers'},
33 endpoint='plan')])
34
35@@ -109,6 +109,7 @@
36 plan_iter = get_test_plan(
37 name, series=series, owner=owner, index=index)
38 plan = next(plan_iter)
39+
40 return {'success': True,
41 'series': series,
42 'name': name,

Subscribers

People subscribed via source and target branches