Merge lp:~marcobiscaro2112/usb-creator/fix-1731977 into lp:usb-creator
Proposed by
Marco Biscaro
Status: | Merged | ||||
---|---|---|---|---|---|
Merge reported by: | Marc Deslauriers | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~marcobiscaro2112/usb-creator/fix-1731977 | ||||
Merge into: | lp:usb-creator | ||||
Diff against target: |
17 lines (+4/-1) 1 file modified
bin/usb-creator-helper (+4/-1) |
||||
To merge this branch: | bzr merge lp:~marcobiscaro2112/usb-creator/fix-1731977 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Marc Deslauriers | Approve | ||
Review via email: mp+333638@code.launchpad.net |
Description of the change
This change ensures that the changes are written to disk before publishing the new progress.
I think that doing a fsync for each progress change is good enough to have a correct progress and not hurt performance.
In fact, I've benchmarked this change twice and doing a periodic fsync results in better performance in my case:
Without fsync: 6m51s / 6m30s
With fsync: 3m32s / 3m31s
To post a comment you must log in.
Looks good, thanks!